-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restricted for timezone for chat rooms #10337
Restricted for timezone for chat rooms #10337
Conversation
Note: There is some issue with workspace in More on issue here |
@mananjadhav I just now noticed you are still assigned to the issue. I am aware you know a C+ review is no need for another C+, so you can skip this one. Thanks! cc: @puneetlath |
@mananjadhav just a reminder to review this one based on our discussion. Thanks! |
Yes @puneetlath, will close it today. Catching up on backlog. |
@puneetlath @Santhosh-Sellavel Change is fine. Tests well. 🎀 👀 🎀
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Fixed Issues
$ #10109
Tests
User A
and create a workspace if you don't have one.User B
to the workspace, ensure the workspace has only two membersUser A
andUser B
User B
timezone should not be shown near compose boxPR Review Checklist
Contributor (PR Author) Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)PR Reviewer Checklist
The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
).src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
have been tested & I retested again)/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)QA Steps
User A
and create a workspace if you don't have one.User B
to the workspace, ensure the workspace has only two membersUser A
andUser B
User B
timezone should not be shown near compose boxScreenshots
Web
Web.mov
Mobile Web
mWeb.mp4
Desktop
Desktop.mov
iOS
iOS.mp4
Android
Android.mp4