[HOLD for payment 2022-10-20] [$250] IOS - Keyboard doesn't persist taps and closes on taping from one to another on Rate or Unit field in Reimburse expenses page @aneequeahmad

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open IOS app user icon to open settings.
2. Select any workspace > reimburse expenses.
3. Tap on Rate text-field so that it gets focus and keyboard opens.
4. Tap on Rate drop down

Expected Result:

Tap should do the action like opens drop down or focus Unit text-field

Actual Result:

Tap is causing the keyboard or dropdown to close and have to tap again to do the action

Workaround:

Unknown

Platform:

Where is this issue occurring?

• iOS

Version Number: 1.2.9.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

bug-rate-unit.mp4

Expensify/Expensify Issue URL:

Issue reported by: @aneequeahmad

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1663236134908079

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @kadiealexander (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[kadiealexander]

Replicated in iOS! Moving to engineering.

[melvin-bot]

Triggered auto assignment to @grgia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Triggered auto assignment to @kevinksullivan (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[melvin-bot]

Triggered auto assignment to @marcochavezf (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[aimane-chnaif]

Proposal

RCA:

App/src/pages/workspace/WorkspacePageWithSections.js

Lines 106 to 108 in b058975

	<ScrollView
	style={[styles.settingsPageBackground, styles.flex1, styles.w100]}
	>

If keyboardShouldPersistTaps prop is not specified in ScrollView, that value is never as default

Solution:

                <ScrollView
+                   keyboardShouldPersistTaps="handled"
                    style={[styles.settingsPageBackground, styles.flex1, styles.w100]}
                >

demo.mov

[sobitneupane]

@aimane-chnaif Does this issue exist in Android and mWeb as well?

[aimane-chnaif]

@aimane-chnaif Does this issue exist in Android and mWeb as well?

@sobitneupane issue happens only on iOS

[sobitneupane]

@marcochavezf proposal from @aimane-chnaif looks good to me.

@aimane-chnaif Please do check other components which make use of WorkspacePageWithSections to make sure they work as expected and no regression caused.

🎀👀🎀
C+ reviewed

[aimane-chnaif]

Please do check other components which make use of WorkspacePageWithSections to make sure they work as expected and no regression caused.

There are total 6 pages which make use of WorkspacePageWithSections:
General settings, Issue cards, Reimburse expenses, Pay bills, Send invoices, Book travel
And there are only 2 pages with input view on which this change is affected:
General settings, Reimburse expenses

Actually, the solution fixes similar issue on General settings page as well:

demo.mov

And no other regressions.

[kevinksullivan]

https://www.upwork.com/jobs/~011b32241123d1fcc0

Hired @sobitneupane for C+ and invited @aneequeahmad for reporting. @aimane-chnaif please apply to the job when you get a chance!

[aneequeahmad]

@kevinksullivan, I have applied to the job. Thanks

[aimane-chnaif]

@aimane-chnaif please apply to the job when you get a chance!

@kevinksullivan Sure, I will apply to the job and create PR after @marcochavezf's final review

[marcochavezf]

Thank you @sobitneupane for the review, assigning @aimane-chnaif 🚀

[melvin-bot]

📣 @aimane-chnaif You have been assigned to this job by @marcochavezf!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[kevinksullivan]

@aimane-chnaif bump to apply for the job when you get a chance.

https://www.upwork.com/jobs/~011b32241123d1fcc0

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.13-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix "iOS - Keyboard doesn't persist taps and closes on taping from one to another on Rate or Unit field in Reimburse expenses page" #11600

If no regressions arise, payment will be issued on 2022-10-20. 🎊

[melvin-bot]

@marcochavezf, @kevinksullivan, @sobitneupane, @aimane-chnaif Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@marcochavezf, @kevinksullivan, @sobitneupane, @aimane-chnaif Eep! 4 days overdue now. Issues have feelings too...

[kevinksullivan]

Sorry all, I missed this one over the weekend + with OOO. @aimane-chnaif just hired you for the job. Can you let me know when you accept so I can pay? @sobitneupane and @aneequeahmad are all set with payments.

[aimane-chnaif]

@kevinksullivan accepted offer. thanks