[HOLD for payment 2022-12-20] Text is clipped on iOS sign in page

[NikkiWines]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. open New Expensify app.
2. go to the login page
3. type an email address that has a ‘g’ in it (e.g. [email protected])

Expected Result:

bottom of ‘g’ isn’t clipped

Actual Result:

bottom of ‘g’ is clipped

Workaround:

N/A user can still use New Expensify

Platform:

• iOS

Version Number: v1.2.36-1
Reproducible in staging?: No
Reproducible in production?: No
Email or phone of affected tester (no customers): N/A
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL: N/A

Issue reported by: @Santhosh-Sellavel
Slack conversation: conversation 1, conversation 2

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c5cab80b99e5d1f4
• Upwork Job ID: 1600914332989022208

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[hungvu193]

Proposal
This cause by the line height of the text input, when the text inside TextInput is bigger than the lineheight, this issue happened.
Solution
We can remove the lineHeight or set it to undefined.

    baseTextInput: {
        fontFamily: fontFamily.EXP_NEUE,
        fontSize: variables.fontSizeNormal,
+       lineHeight: undefined,
-       lineHeight: variables.fontSizeNormalHeight,
        color: themeColors.text,
        paddingTop: 23,
        paddingBottom: 8,
        paddingHorizontal: 11,
        borderWidth: 0,
    },

Result:

[joekaufmanexpensify]

Triaging:

From this SO: https://stackoverflow.com/c/expensify/questions/14418

• The "bug" is actually a bug:
• The bug is not a duplicate report of an existing GH (close the GH and add any novel details to the original GH instead):
• The bug is reproducible, following the reproduction steps:
• If you're unable to reproduce the bug, add the Needs reproduction label. Comment on the issue outlining the steps you took to try to reproduce the bug, your results and tag the issue reporter and the Applause QA member who created the issue. Ask them to clarify reproduction steps and/or to check the reproduction steps again. Close issue.:
• The GH template is filled out as fully as possible -- this means the GH body and title are clear (ie. could an external contributor understand it and work on it?):
• The GH was created by an Expensify employee or a QA tester:
• If the bug is an OldDot issue, you should decide whether it is widespread enough to justify fixing or it is better to wait for reunification. If it's better to wait, close the GH & provide this justification:
• If there's a link to Slack, check the discussion to see if we decided not to fix it:
• Decide if the GH should be resolved by an External contributor or Internal engineer, add the appropriate label:

[joekaufmanexpensify]

Reproduced in iOS:

[joekaufmanexpensify]

@NikkiWines I'm assuming this one is good to be external?

[NikkiWines]

@joekaufmanexpensify was going to handle it myself since it's such an easy fix, hence not applying the External label yet.

@hungvu193, @fedirjh, please be aware that issues that aren't marked as External may be worked on internally. For more details please see the propose a solution for the job section of the contributing readme

[melvin-bot]

Current assignee @NikkiWines is eligible for the Engineering assigner, not assigning anyone new.

[joekaufmanexpensify]

PR is up and under review!

[Santhosh-Sellavel]

@joekaufmanexpensify I'm eligible for reporting bonus here.

[joekaufmanexpensify]

Re-opening to handle payment.

[joekaufmanexpensify]

Okay, we need to issue two payments here:

• $250 reporting payment to @Santhosh-Sellavel
• $1,000 for PR review to @mollfpr

[melvin-bot]

Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

📣 @mollfpr You have been assigned to this job by @joekaufmanexpensify!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mollfpr / @NikkiWines] The PR that introduced the bug has been identified. Link to the PR: Remove clipped texts throughout the app when device font size is increased #10312
• [@mollfpr / @NikkiWines] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Remove clipped texts throughout the app when device font size is increased #10312 (comment)
• [@mollfpr / @NikkiWines] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion here
• [@joekaufmanexpensify] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here: https://github.com/Expensify/Expensify/issues/250673

[NikkiWines]

Hmm, it's a little difficult to backtrace when this was first introduced actually because the modified line previously hadn't been modified for over a year

I suspect it was #10312 that introduced it but it's difficult to trace back. Will do some more digging this week or early next week to see if we can narrow it down

[Santhosh-Sellavel]

Recent font changes could also may be a problem, I guess.

[Luke9389]

Just want to reiterate that I've got this one covered in this PR: #12447
I see you're doing the RCA, but just putting this here for posterity. 👍

[joekaufmanexpensify]

Next step is bug zero checklist

[joekaufmanexpensify]

@Luke9389 Just for my own understanding as we finish up this issue, your most recent message means that you're fixing the regression that was reported here in the PR you linked, right?

[joekaufmanexpensify]

Okay, just summarizing payment next steps as we approach tomorrow:

• @Santhosh-Sellavel - $250 for reporting the bug originally.
• @mollfpr - $500 for PR review (This is reduced by 50% from $1000 originally as this PR introduced a regression).
• @jatinsonijs - bonus for regression reporting. I believe this is also $250, but am confirming internally.

[joekaufmanexpensify]

Proposed new regression test here.

[Luke9389]

Just for my own understanding as we finish up this issue, your most recent message means that you're fixing the regression that was reported #13336 (comment) in the PR you linked, right?

That's correct

[joekaufmanexpensify]

Great, thanks for confirming!

[jatinsonijs]

Okay, just summarizing payment next steps as we approach tomorrow:

• @Santhosh-Sellavel - $250 for reporting the bug originally.
• @mollfpr - $500 for PR review (This is reduced by 50% from $1000 originally as this PR introduced a regression).
• @jatinsonijs - bonus for regression reporting. I believe this is also $250, but am confirming internally.

@joekaufmanexpensify can you plz confirm, should I apply on https://www.upwork.com/jobs/~01c5cab80b99e5d1f4 ?

[joekaufmanexpensify]

Yes please do. You'll get $250 regression reporting bonus.

[jatinsonijs]

Yes please do. You'll get $250 regression reporting bonus.

Thanks, done

[joekaufmanexpensify]

@jatinsonijs Great! Just extended offer.

[joekaufmanexpensify]

@mollfpr $500 payment sent and contract ended!

[joekaufmanexpensify]

@Santhosh-Sellavel $250 payment sent and contract ended!

[joekaufmanexpensify]

Linked regression test above in BZ checklist. All that's left here is to pay the regression reporting bonus, and then the last few items for @NikkiWines and @mollfpr in the BZ checklist.

[jatinsonijs]

@joekaufmanexpensify I have accepted the contract.

[mollfpr]

[@mollfpr / @NikkiWines] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Slack thread here

[joekaufmanexpensify]

@jatinsonijs payment sent and contract ended!

[joekaufmanexpensify]

Job is closed in upwork. @mollfpr and @NikkiWines are working on their remaining BZ checklist steps, and then we can close this!

[joekaufmanexpensify]

I'm going to be OOO from tomorrow - January 2nd. All that's left here is the engineering section of the BZ checklist. I'm going to change this to weekly in the interim, as this is not urgent.

@NikkiWines and @mollfpr, if you have a chance to finish up the BZ checklist before then, that's great. If not, I'll change the prioritization back to daily when I'm back so we can finish this up.

[NikkiWines]

BZ checklist is completed, any further discussion can happen in the BZ slack thread. Closing