Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock /App issues until the external label is added #13395

Closed
JmillsExpensify opened this issue Dec 7, 2022 · 4 comments
Closed

Lock /App issues until the external label is added #13395

JmillsExpensify opened this issue Dec 7, 2022 · 4 comments
Assignees
@marcaaron
Labels
Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2

Comments

@JmillsExpensify
Copy link

JmillsExpensify commented Dec 7, 2022 •
edited by marcaaron
Loading

In order to ensure fairness in compensation, and also avoid proposals being added to /App issues before the external label is added – per our contributor guidelines, let's lock all issues upon creation. They can subsequently be unlocked once we're aligned on the path forward, and the work is specifically for external contributors.
@JmillsExpensify JmillsExpensify added Weekly KSv2 Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff labels Dec 7, 2022
@0xmiros
Copy link
Contributor

0xmiros commented Dec 7, 2022

100% agree with this suggestion.
Here's the main reason why contributors submit proposal before External label is added and suggestion to prevent this:
#11195 (comment) and the following comment.
#12483 (comment) and the following comment.

@marcaaron marcaaron self-assigned this Dec 7, 2022
@michaelhaxhiu michaelhaxhiu mentioned this issue Dec 8, 2022
Closed
@s77rt s77rt mentioned this issue Dec 9, 2022
Closed
@melvin-bot

This comment was marked as off-topic.

Sign in to view
@stitesExpensify stitesExpensify mentioned this issue Dec 9, 2022
Closed
@dylanexpensify
Copy link
Contributor

@marcaaron any updates on this?

@dylanexpensify
Copy link
Contributor

posted here to update #expensify-open-source

@francoisl francoisl mentioned this issue Dec 14, 2022
Closed
mallenexpensify added a commit that referenced this issue Dec 21, 2022
@mallenexpensify
Update CONTRIBUTING.md
f6210b7 
Completely removed line 113 cuz issue commenting by contributors (inc. C+) is blocked until after `External` is added. 
#13395 

> - Note: Issues that have not had the `External` label applied have not yet been approved for implementation. This means, if you propose a solution to an issue without the `External` label (which you are allowed to do) it is possible that the issue will be fixed internally. If the `External` label has not yet been applied, Expensify has the right to use your proposal to fix said issue, without providing compensation for your solution. This process covers the very rare instance where we need or want to fix an issue internally.
@mallenexpensify mallenexpensify mentioned this issue Dec 21, 2022
Merged
53 tasks
@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcaaron marcaaron

Labels
Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@JmillsExpensify @marcaaron @dylanexpensify @0xmiros