Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect image shown in carousel for mobile Safari #21177

Closed
bfitzexpensify opened this issue Jun 21, 2023 · 6 comments
Closed

Incorrect image shown in carousel for mobile Safari #21177

bfitzexpensify opened this issue Jun 21, 2023 · 6 comments
Assignees

Comments

@bfitzexpensify
Copy link
Contributor

Opening this issue as a continuation of the work done in #18150.

cc @kidroca

Outstanding state of things for context, taking @kidroca's comment in #18150 (comment):

From my end, I no longer encounter the issue of the carousel showing the wrong image during normal usage. The issue appears to be exclusive to mobile Safari on the simulator when I'm testing the app.

I've traced this problem back to the modal handling logic in react-native-web. Currently, I am working on developing a standalone bug example to highlight this issue and intend to open a separate ticket upstream.

If there are no longer reports of the carousel bug, I would propose we close this ticket. We can then initiate a new one specifically to track and monitor the mobile Safari-related issue.

I am also able to reproduce this reliably on mobile Safari

@bfitzexpensify
Copy link
Contributor Author

@kidroca you're not appearing in the assignment list for me — are you able to self-assign?

@kidroca
Copy link
Contributor

kidroca commented Jun 21, 2023

I think I need to comment on the issue and now you should be able to assign me

@kidroca
Copy link
Contributor

kidroca commented Jun 23, 2023

Here's the related react-native-web issue:

I've found out the problem happens not only on mobile Safari, but on desktop Safari as well
The bug does not occur on Chrome or the Desktop App which is based on Chromium

@melvin-bot
Copy link

melvin-bot bot commented Jul 28, 2023

This issue has not been updated in over 15 days. @kidroca eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@kidroca
Copy link
Contributor

kidroca commented Jul 31, 2023

I'm closely following the recently created issue in react-native-web:

As of now, there has been no response or priority assigned to this ticket. This lack of feedback creates uncertainty, making it challenging to work on a fix. It would be helpful to know if the mentioned issue is already being addressed in an upcoming update or if there are any plans to modify the modal focus lock logic.

@melvin-bot melvin-bot bot closed this as completed Oct 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 12, 2023

@kidroca, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

kidroca added a commit to kidroca/Expensify.cash that referenced this issue Apr 22, 2024
- Fixed an issue with carousel scrolling in the AttachmentCarousel component
- Implemented a new pan gesture for smoother scrolling experience
- Adjusted layout calculations for optimal rendering of attachments

Related to:
- Expensify#23546
- Expensify#39833
- Expensify#22318
- Expensify#21177
- Expensify#31166
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants