Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-03-26] [$500][Simplified Collect][Tags] Create TagSettingsPage #37313

Closed
luacmartins opened this issue Feb 27, 2024 · 23 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Weekly KSv2

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Feb 27, 2024

Implement this section of the Simplified Collect: Tags design doc

cc @waterim

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ef8d6d5d785755ce
  • Upwork Job ID: 1762500700268445696
  • Last Price Increase: 2024-02-27
@luacmartins luacmartins added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 27, 2024
@luacmartins luacmartins self-assigned this Feb 27, 2024
@luacmartins luacmartins moved this to Release 2: From Setup > Export in [#whatsnext] Wave 08 - Collect Plan Admins Feb 27, 2024
Copy link

melvin-bot bot commented Feb 27, 2024

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@waterim
Copy link
Contributor

waterim commented Feb 27, 2024

Hello, Im Artem from Callstack and would like to take this one

@luacmartins luacmartins added External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Feb 27, 2024
@melvin-bot melvin-bot bot changed the title [HOLD #37309][Simplified Collect][Tags] Create TagSettingsPage [$500] [HOLD #37309][Simplified Collect][Tags] Create TagSettingsPage Feb 27, 2024
Copy link

melvin-bot bot commented Feb 27, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01ef8d6d5d785755ce

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 27, 2024
Copy link

melvin-bot bot commented Feb 27, 2024

Current assignee @abekkala is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Feb 27, 2024
Copy link

melvin-bot bot commented Feb 27, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 27, 2024
@luacmartins luacmartins added Weekly KSv2 Daily KSv2 and removed Daily KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2 labels Feb 27, 2024
@abekkala
Copy link
Contributor

abekkala commented Feb 27, 2024

@luacmartins was the Help Wanted meant to be removed for this one?

@luacmartins
Copy link
Contributor Author

yea, @waterim is working on this

@melvin-bot melvin-bot bot added the Overdue label Mar 1, 2024
@trjExpensify trjExpensify moved this to Release 1: Spring 2024 (May) in [#whatsnext] #wave-collect Mar 5, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 7, 2024
Copy link

melvin-bot bot commented Mar 8, 2024

@hoangzinh, @abekkala, @luacmartins, @waterim Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Mar 12, 2024

@hoangzinh, @abekkala, @luacmartins, @waterim 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@hoangzinh
Copy link
Contributor

Hi @waterim please let us know when the PR is ready.

@luacmartins
Copy link
Contributor Author

We'll start working on this next

@waterim waterim mentioned this issue Mar 14, 2024
58 tasks
@waterim
Copy link
Contributor

waterim commented Mar 14, 2024

Created draft!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 Weekly KSv2 labels Mar 14, 2024
@melvin-bot melvin-bot bot changed the title [$500][Simplified Collect][Tags] Create TagSettingsPage [HOLD for payment 2024-03-26] [$500][Simplified Collect][Tags] Create TagSettingsPage Mar 19, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 19, 2024
Copy link

melvin-bot bot commented Mar 19, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Mar 19, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.54-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-03-26. 🎊

For reference, here are some details about the assignees on this issue:

  • @hoangzinh requires payment (Needs manual offer from BZ)
  • @waterim does not require payment (Contractor)

Copy link

melvin-bot bot commented Mar 19, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@hoangzinh] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@abekkala
Copy link
Contributor

PAYMENT SUMMARY FOR MAR 26

Fix: @waterim - does not require payment
PR Review: @hoangzinh [$500, if no regressions] Offer

Please propose a regression test

@hoangzinh
Copy link
Contributor

Regression Test Proposal

Pre-condition: User A must be an admin of a collect workspace

  1. Sign in User A
  2. Go to Settings -> Workspaces -> Select collect workspace above
  3. Go to the Tags page
  4. Create a new tag
  5. Tap on the tag created in step 5
  6. Verify it opens the Tag settings page
  7. Enable the "Enabled tag" toggle
  8. Tap outside to close the Tag settings page
  9. Tap on the tag created in step 5 again
  10. Verify the "Enabled tag" toggle shows up as enabled

Do we agree 👍 or 👎

@luacmartins
Copy link
Contributor Author

We'll add test steps once the feature is fully implemented. No need to do that now.

@abekkala
Copy link
Contributor

@slafortune will be handling payment for me while I'm ooo

PAYMENT SUMMARY FOR MAR 26

Fix: @waterim - does not require payment
PR Review: @hoangzinh [$500, if no regressions] Offer

@slafortune
Copy link
Contributor

Paid ✅

@github-project-automation github-project-automation bot moved this from Release 1: Spring 2024 (May) to Done in [#whatsnext] #wave-collect Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Weekly KSv2
Projects
No open projects
Archived in project
Status: Release 2: From Setup > Export
Development

No branches or pull requests

5 participants