Create TagSettingsPage #38335

waterim · 2024-03-14T18:07:34Z

Details

Tag Settings Page

Fixed Issues

$ #37313

Tests

Go to workspace settings
Go to tags (enable in more features)
click on any tag
try to enable/disable tag

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

None

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile

melvin-bot · 2024-03-14T18:20:31Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

luacmartins

Looking good. Left a few comments

src/libs/actions/Policy.ts

src/pages/workspace/tags/TagSettingsPage.tsx

src/libs/Navigation/linkingConfig/config.ts

src/libs/actions/Policy.ts

src/pages/workspace/tags/TagSettingsPage.tsx

luacmartins · 2024-03-15T14:59:53Z

@waterim let me know when you address the comments and resolve conflicts. Let's get this merged!

waterim · 2024-03-15T16:38:32Z

@luacmartins Resolved conflict and updated

hoangzinh · 2024-03-15T16:50:12Z

Gonna complete review checklist soon

hoangzinh · 2024-03-15T17:06:12Z

@waterim It's weird from my end, I'm unable to toggle the enable button

Screen.Recording.2024-03-16.at.00.04.14.mov

Have you found the same bug?

waterim · 2024-03-15T17:09:51Z

@hoangzinh damn,checking

waterim · 2024-03-15T17:11:13Z

Weird, it works for me

waterim · 2024-03-15T17:12:04Z

Hmm, okay, it doesnt work for newly created tags

waterim · 2024-03-15T17:14:59Z

Fixed, pushed

hoangzinh · 2024-03-15T17:15:15Z

src/libs/actions/Policy.ts

+                                    ...policyTag.tags[key],
+                                    errors: null,
+                                    pendingFields: {
+                                        enabled: null,
+                                    },


@waterim I think because of our success optimistic data here. It reset data

yes, updated

Because of type check, it makes us update more data to Onyx here. Usually we just update

acc[key] = { errors: null, pendingFields: { enabled: null, }, };

we can leave as now, as categories done, to have consistency

waterim · 2024-03-15T17:15:39Z

It was because of the removal from reduce data regarding the tags to update, reduce is generating new object, thats why we need to pass it as well

hoangzinh · 2024-03-15T17:29:42Z

src/libs/actions/Policy.ts

+                value: {
+                    [policyTag.name]: {
+                        tags: {
+                            ...Object.keys(tagsToUpdate).reduce<PolicyTags>((acc, key) => {


@waterim NAB we don't need a spread operator here.

hoangzinh · 2024-03-15T17:44:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-03-16.at.00.49.51.android.mov

Android: mWeb Chrome

Screen.Recording.2024-03-16.at.00.51.00.android.chrome.mov

iOS: Native

Screen.Recording.2024-03-16.at.00.48.20.ios.mov

iOS: mWeb Safari

Screen.Recording.2024-03-16.at.00.45.49.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2024-03-16.at.00.33.54.web.mov

MacOS: Desktop

Screen.Recording.2024-03-16.at.00.38.04.desktop.mov

hoangzinh

LGTM

OSBotify · 2024-03-15T18:04:33Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-03-18T16:30:55Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.54-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

DylanDylann · 2024-03-18T16:50:45Z

src/pages/workspace/tags/TagSettingsPage.tsx

+function TagSettingsPage({route, policyTags}: TagSettingsPageProps) {
+    const styles = useThemeStyles();
+    const {translate} = useLocalize();
+    const policyTag = useMemo(() => PolicyUtils.getTagList(policyTags, 0), [policyTags]);


Crash App from this line

Screen.Recording.2024-03-18.at.23.49.51.mov

Do you mean not found page appears?

OSBotify · 2024-03-19T23:11:59Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.4.54-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ntdiary · 2024-04-26T13:44:41Z

src/pages/workspace/tags/TagSettingsPage.tsx

+                                </View>
+                            </View>
+                        </OfflineWithFeedback>
+                        <MenuItemWithTopDescription


Coming from #39169.
We added the offline behavior for this menu item. :)

tag settings page

88a193d

luacmartins self-requested a review March 14, 2024 18:09

waterim added 2 commits March 14, 2024 19:12

merge

b71b348

fix lint and ts

f1122da

waterim marked this pull request as ready for review March 14, 2024 18:20

waterim requested a review from a team as a code owner March 14, 2024 18:20

melvin-bot bot requested review from hoangzinh and removed request for a team March 14, 2024 18:20

clenup

2038d55

luacmartins requested changes Mar 14, 2024

View reviewed changes

hoangzinh reviewed Mar 15, 2024

View reviewed changes

src/libs/actions/Policy.ts Show resolved Hide resolved

src/pages/workspace/tags/TagSettingsPage.tsx Outdated Show resolved Hide resolved

waterim added 2 commits March 15, 2024 17:30

Merge remote-tracking branch 'upstream/main' into feat-37313-tagSettings

e72a1e1

resolved changes

8654a07

fix

397e102

hoangzinh reviewed Mar 15, 2024

View reviewed changes

hoangzinh approved these changes Mar 15, 2024

View reviewed changes

melvin-bot bot requested a review from luacmartins March 15, 2024 17:53

luacmartins approved these changes Mar 15, 2024

View reviewed changes

luacmartins merged commit 40acece into Expensify:main Mar 15, 2024
16 of 22 checks passed

github-actions bot mentioned this pull request Mar 18, 2024

Deploy Checklist: New Expensify 2024-03-18 #38489

Closed

65 tasks

DylanDylann reviewed Mar 18, 2024

View reviewed changes

DylanDylann mentioned this pull request Mar 18, 2024

Create EditTagPage #38240

Merged

58 tasks

melvin-bot bot mentioned this pull request Mar 19, 2024

[HOLD for payment 2024-03-26] [$500][Simplified Collect][Tags] Create TagSettingsPage #37313

Closed

ntdiary reviewed Apr 26, 2024

View reviewed changes

ntdiary mentioned this pull request Apr 26, 2024

[HOLD for payment 2024-04-25] [$500] Tags & Categories - Name row in item RHP is not grayed out when edited offline #39169

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create TagSettingsPage #38335

Create TagSettingsPage #38335

waterim commented Mar 14, 2024 •

edited

Loading

melvin-bot bot commented Mar 14, 2024

luacmartins left a comment

luacmartins commented Mar 15, 2024

waterim commented Mar 15, 2024

hoangzinh commented Mar 15, 2024

hoangzinh commented Mar 15, 2024

waterim commented Mar 15, 2024

waterim commented Mar 15, 2024

waterim commented Mar 15, 2024

waterim commented Mar 15, 2024

hoangzinh Mar 15, 2024 •

edited

Loading

waterim Mar 15, 2024

hoangzinh Mar 15, 2024

waterim Mar 15, 2024

waterim commented Mar 15, 2024

hoangzinh Mar 15, 2024 •

edited

Loading

hoangzinh commented Mar 15, 2024 •

edited

Loading

hoangzinh left a comment

OSBotify commented Mar 15, 2024

OSBotify commented Mar 18, 2024

DylanDylann Mar 18, 2024

hoangzinh Mar 19, 2024

OSBotify commented Mar 19, 2024

ntdiary Apr 26, 2024

Create TagSettingsPage #38335

Create TagSettingsPage #38335

Conversation

waterim commented Mar 14, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Mar 14, 2024

luacmartins left a comment

Choose a reason for hiding this comment

luacmartins commented Mar 15, 2024

waterim commented Mar 15, 2024

hoangzinh commented Mar 15, 2024

hoangzinh commented Mar 15, 2024

waterim commented Mar 15, 2024

waterim commented Mar 15, 2024

waterim commented Mar 15, 2024

waterim commented Mar 15, 2024

hoangzinh Mar 15, 2024 • edited Loading

Choose a reason for hiding this comment

waterim Mar 15, 2024

Choose a reason for hiding this comment

hoangzinh Mar 15, 2024

Choose a reason for hiding this comment

waterim Mar 15, 2024

Choose a reason for hiding this comment

waterim commented Mar 15, 2024

hoangzinh Mar 15, 2024 • edited Loading

Choose a reason for hiding this comment

hoangzinh commented Mar 15, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

hoangzinh left a comment

Choose a reason for hiding this comment

OSBotify commented Mar 15, 2024

OSBotify commented Mar 18, 2024

DylanDylann Mar 18, 2024

Choose a reason for hiding this comment

hoangzinh Mar 19, 2024

Choose a reason for hiding this comment

OSBotify commented Mar 19, 2024

ntdiary Apr 26, 2024

Choose a reason for hiding this comment

waterim commented Mar 14, 2024 •

edited

Loading

hoangzinh Mar 15, 2024 •

edited

Loading

hoangzinh Mar 15, 2024 •

edited

Loading

hoangzinh commented Mar 15, 2024 •

edited

Loading