[HOLD for payment 2024-04-09] HIGH: [Performance] [$500] Eliminate 3x re-render on switching to new chat

[quinthar]

Problem:

It really seems like every time I switch to a chat, it renders the page like 3 times (ie, it shows, and then blinks 2x more looking like it re-renders). On web it's not that big a deal, but I find my mobile app is extremely sluggish, and I think it's for the accumulation of reasons like this.

Solution:

?? not sure. Being discussed in Slack here, along with video.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01574932395779d237
• Upwork Job ID: 1773397513149165568
• Last Price Increase: 2024-03-28

[perunt]

I'll take a look at this

[melvin-bot]

Triggered auto assignment to @NikkiWines, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01574932395779d237

[melvin-bot]

Current assignee @paultsimura is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.58-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Blinking on chat switching #39040

If no regressions arise, payment will be issued on 2024-04-09. 🎊

For reference, here are some details about the assignees on this issue:

• @paultsimura requires payment (Needs manual offer from BZ)
• @perunt does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@paultsimura] The PR that introduced the bug has been identified. Link to the PR:
• [@paultsimura] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@paultsimura] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@paultsimura] Determine if we should create a regression test for this bug.
• [@paultsimura] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Christinadobrzyn]

Payouts due:

• Contributor+: $500 @paultsimura (Upwork offer - https://www.upwork.com/nx/wm/offer/101774668)

Upwork job is here.

@paultsimura do we need a regression test for this?

[paultsimura]

Thanks @Christinadobrzyn, I'll fill out the checklist today

[paultsimura]

• The PR that introduced the bug has been identified. Link to the PR: HIGH: (Comment linking: Step 4) Main "glue" PR for Comment Linking #30269
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/30269/files#r1555664471
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug: No – this was a missed part of the large Comment Linking PR, which required some polishing
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

[Christinadobrzyn]

Thanks @paultsimura! I paid you in Upwork based on this summary - #38909 (comment)

I think this is good to close. Feel free to let me know if I missed anything!