[HOLD for payment 2024-07-17] Distance - Amount shows 0.03 instead of being blank when removing a waypoint offline

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.77-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Create a distance expense with three waypoints.
3. Go to transaction thread.
4. Go offline.
5. Click Distance.
6. Remove the last stop.
7. Save the new distance.

Expected Result:

The Amount field should be empty while it is still pending (production behavior).

Actual Result:

The Amount field shows 0.03.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6495349_1717003395262.20240530_012033.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @greg-schroeder

[melvin-bot]

Triggered auto assignment to @deetergp (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@greg-schroeder FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Nodebrute]

I think it's a regression caused by this PR #42337

[greg-schroeder]

@nkdengineer @neil-marcellini @akinwale thoughts on #42784 (comment)?

[nkdengineer]

It's late for me now. I'll create a PR to fix this bug in the morning.

[deetergp]

Should this continue to be a blocker till @nkdengineer comes back online and fixes it?

[greg-schroeder]

Let's remove it from the list of deploy blockers (requires being offline to reproduce, making it pretty low prio), but have @nkdengineer get a fix up tomorrow

[nkdengineer]

@akinwale The PR to fix regression here #42833.

[deetergp]

Thanks for being on top of it @nkdengineer. @fedirjh, it looks like you're the lucky reviewer.

[greg-schroeder]

Nice thanks @nkdengineer!

[fedirjh]

it looks like you're the lucky reviewer.

@deetergp It seems like @akinwale has reviewed the original PR. I can review it shortly if it's urgent.

[akinwale]

I will review the PR.

[melvin-bot]

This issue has not been updated in over 15 days. @deetergp, @greg-schroeder eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[greg-schroeder]

Bump I think @akinwale and also @deetergp on this PR review: #42833

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix wrong amount is displayed when updating waypoint in offline #42833

If no regressions arise, payment will be issued on 2024-07-17. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@deetergp] The PR that introduced the bug has been identified. Link to the PR:
• [@deetergp] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@deetergp] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@deetergp] Determine if we should create a regression test for this bug.
• [@deetergp] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[deetergp]

I ended up having nothing to do with that PR. Should @akinwale & @neil-marcellini be on this one?

[greg-schroeder]

This was a regression from #41817