Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Due for payment 2025-02-19] [$500] Android- Composer- Only haptic feedback but no paste menu when long tapping on the composer #50682

Closed
1 of 6 tasks
IuliiaHerets opened this issue Oct 12, 2024 · 58 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Oct 12, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.48-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Break down in numbered stepsPrecondition:

  • User has copied any content on the device.
  1. Launch New Expensify app.
  2. Go to DM.
  3. Long tap on the composer (do not make the keyboard appear).
  4. Note that there is haptic feedback but no menu to paste when long tapping on the composer while keyboard is hidden.
  5. Tap on the composer.
  6. Dismiss keyboard by using device back navigation (device back button or swipe gesture to dismiss).
  7. Long tap on the composer.
  8. Note that now there is menu to paste.

Expected Result:

In Step 4, when the chat is opened for the first time, long tapping on the composer should bring up the menu to paste.

Actual Result:

In Step 4, when the chat is opened for the first time, there is no menu to paste when long tapping on the composer, and there is only haptic feedback.
In Step 8, the menu to paste only shows up after bringing up the keyboard and dismissing it.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6632256_1728681133881.1728680628113_Screen_Recording_20241012_050259_New_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021846255346776510837
  • Upwork Job ID: 1846255346776510837
  • Last Price Increase: 2025-01-15
  • Automatic offers:
    • QichenZhu | Contributor | 105814058
Issue OwnerCurrent Issue Owner: @sakluger
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Oct 12, 2024
Copy link

melvin-bot bot commented Oct 12, 2024

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot melvin-bot bot removed the Hourly KSv2 label Oct 12, 2024
Copy link

melvin-bot bot commented Oct 12, 2024

Triggered auto assignment to @MarioExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Oct 12, 2024

💬 A slack conversation has been started in #expensify-open-source

@MarioExpensify
Copy link
Contributor

The issue already happens in Production:

WhatsApp.Video.2024-10-14.at.17.48.30.mp4

Removing the DeployBlocker

@MarioExpensify MarioExpensify added External Added to denote the issue can be worked on by a contributor and removed DeployBlockerCash This issue or pull request should block deployment labels Oct 14, 2024
Copy link

melvin-bot bot commented Oct 15, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021846255346776510837

@melvin-bot melvin-bot bot changed the title Android- Composer- Only haptic feedback but no paste menu when long tapping on the composer [$250] Android- Composer- Only haptic feedback but no paste menu when long tapping on the composer Oct 15, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 15, 2024
Copy link

melvin-bot bot commented Oct 15, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

@sakluger
Copy link
Contributor

Waiting for proposals.

@melvin-bot melvin-bot bot added the Overdue label Oct 17, 2024
@sakluger
Copy link
Contributor

Not overdue, we have no proposals yet.

@melvin-bot melvin-bot bot removed the Overdue label Oct 18, 2024
Copy link

melvin-bot bot commented Oct 21, 2024

@sakluger, @mollfpr, @MarioExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Oct 21, 2024
Copy link

melvin-bot bot commented Oct 22, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Jan 28, 2025

@sakluger, @mollfpr, @QichenZhu, @MarioExpensify Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label Jan 28, 2025
@QichenZhu
Copy link
Contributor

Still working on the PR.

@MarioExpensify
Copy link
Contributor

@QichenZhu do you have an ETA?

@QichenZhu
Copy link
Contributor

@mollfpr I wanted to test the PR further, but I’m not feeling well today. I’ll open it this week, but if it’s urgent, feel free to review it now.

cc @MarioExpensify

@melvin-bot melvin-bot bot removed the Overdue label Jan 29, 2025
@MarioExpensify
Copy link
Contributor

@QichenZhu we can wait, take your time! Thanks for the update!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Feb 1, 2025
@QichenZhu
Copy link
Contributor

Proposal

Updated to include solutions for the iOS Safari issue discovered during PR phase.

@melvin-bot melvin-bot bot added Daily KSv2 Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 Daily KSv2 labels Feb 5, 2025
@melvin-bot melvin-bot bot changed the title [$500] Android- Composer- Only haptic feedback but no paste menu when long tapping on the composer [Due for payment 2025-02-19] [$500] Android- Composer- Only haptic feedback but no paste menu when long tapping on the composer Feb 12, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 12, 2025
Copy link

melvin-bot bot commented Feb 12, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Feb 12, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.96-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-19. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Feb 12, 2025

@mollfpr @sakluger @mollfpr The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 18, 2025
@sakluger
Copy link
Contributor

@mollfpr could you please complete the BZ checklist here? Thanks!

@sakluger
Copy link
Contributor

sakluger commented Feb 19, 2025

Summarizing payment on this issue:

Contributor: @QichenZhu $500, paid via Upwork
Contributor+: @mollfpr $500, request on Newdot

@mollfpr
Copy link
Contributor

mollfpr commented Feb 20, 2025

BugZero Checklist:

  • [Contributor] Classify the bug:
Bug classification

Source of bug:

  • 1a. Result of the original design (eg. a case wasn't considered)
  • 1b. Mistake during implementation
  • 1c. Backend bug
  • 1z. Other:

Where bug was reported:

  • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
  • 2b. Reported on staging (eg. found during regression or PR testing)
  • 2d. Reported on a PR
  • 2z. Other:

Who reported the bug:

  • 3a. Expensify user
  • 3b. Expensify employee
  • 3c. Contributor
  • 3d. QA
  • 3z. Other:
  • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

    Link to comment: https://github.com/Expensify/App/pull/51172/files#r1962828838

  • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

    Link to discussion: Not a critical issue.

  • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

I think we don't need the regression test the code RCA is removed.

Regression Test Proposal Template
  • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

    Link to issue:

Regression Test Proposal

Precondition:

  • Copy some text to the clipboard.

Test:

Do we agree 👍 or 👎

@sakluger
Copy link
Contributor

Thanks! Payment summary is here: #50682 (comment)

@garrettmknight
Copy link
Contributor

$500 approved for @mollfpr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
Status: Done
Development

No branches or pull requests

8 participants