[HOLD for payment 2024-12-11] [$250] Expense - Tag in A: B style is displayed as A\: B in expense preview

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.68-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Issue was found when executing this PR: #52758
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• Workspace has a tag in A: B format.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit an expense with tag in A: B format.
4. Submit another expense if there is no expense.
5. Go to expense report.

Expected Result:

Tag in A: B style will be displayed as A: B in expense preview.

Actual Result:

Tag in A: B style is displayed as A: B in expense preview.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6679171_1732805584882.20241128_225038.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021862164320724693300
• Upwork Job ID: 1862164320724693300
• Last Price Increase: 2024-11-28

Issue Owner

Current Issue Owner: @sonialiap

[melvin-bot]

Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[etCoderDysto]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - Tag in A: B style is displayed as A: B in expense preview

What is the root cause of that problem?

Here we are getting tag name that with A\: B format, and we are displaying it without removing \ using PolicyUtils.getCleanedTagName

App/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx

Line 468 in 64eaf2f

{tag}

App/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx

Line 109 in 64eaf2f

tag,

What changes do you think we should make in order to solve the problem?

We should clean the tag using PolicyUtils.getCleanedTagName(tag)here

Or we can create a new variable tagName and clean the tag at the top of the function here

What alternative solutions did you explore? (Optional)

[mkzie2]

@carlosmiceli Please assign me here, and I will raise a follow-up PR.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021862164320724693300

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[mkzie2]

@dukenv0307 The PR is ready.

[dukenv0307]

@mkzie2 Thanks for the quick PR, I'll review in a few hours

[dukenv0307]

@mkzie2 Is it your regression or the new issue (related to the original one)? If it's the regression @sobitneupane should review it, otherwise I'll review since we made it external cc @carlosmiceli

[mkzie2]

It's not a deploy blocker and it's external. I think you can start reviewing.

[dukenv0307]

@mkzie2 Thanks, I'll take it

[mkzie2]

This is a follow up from my previous PR. So no need payment for me here cc @sonialiap

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.70-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Clean tag name #53262

If no regressions arise, payment will be issued on 2024-12-11. 🎊

For reference, here are some details about the assignees on this issue:

• @dukenv0307 requires payment through NewDot Manual Requests
• @mkzie2 requires payment (Needs manual offer from BZ)

[melvin-bot]

@dukenv0307 @sonialiap @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @dukenv0307 owed $250 via NewDot
• ROLE: @mkzie2 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@sonialiap)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1862164320724693300/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[dukenv0307]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: https://github.com/Expensify/App/pull/52758/files#r1879680408

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue: https://github.com/Expensify/Expensify/issues/452468

Regression Test Proposal

Test:

• Precondition:

Workspace has a tag in A: B format.

1. Open workspace chat.
2. Submit an expense with tag in A: B format.
3. Submit another expense if there is no expense.
4. Go to the expense report.
5. Verify that the tag display in the preview is A:B

Do we agree 👍 or 👎

[sonialiap]

Payment summary:

• @dukenv0307 $250 via NewDot - thank you for being so prompt with the checklist!
• @mkzie2 no payment since this is a follow up PR

[mkzie2]

@sonialiap Based on this comment, no need a payment for me here.

[JmillsExpensify]

$250 approved for @dukenv0307