Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-12-20] [$250] Track - Workspace list doesn't show up when categorizing track expense #53274

Closed
7 of 8 tasks
lanitochka17 opened this issue Nov 28, 2024 · 30 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@lanitochka17
Copy link

lanitochka17 commented Nov 28, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.68-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: #52737
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Pre condition: Have multiple workspaces

  1. Navigate to staging.new.expensify.com
  2. Navigate to self DM
  3. Create a track expense
  4. Click on Categorize it
  5. Select a category
  6. Go back one step

Expected Result:

When categorizing it workspace list should show up for the user to select from

Actual Result:

No workspace list shows up on step 4 but category list shows up, then on step 6 workspace list shows up when going back

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6679353_1732817436655.bandicam_2024-11-28_21-05-54-589.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021862235357007622822
  • Upwork Job ID: 1862235357007622822
  • Last Price Increase: 2024-11-28
  • Automatic offers:
    • nkdengineer | Contributor | 105163105
Issue OwnerCurrent Issue Owner: @flodnv
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Nov 28, 2024
Copy link

melvin-bot bot commented Nov 28, 2024

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Nov 28, 2024

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@flodnv flodnv added the External Added to denote the issue can be worked on by a contributor label Nov 28, 2024
@melvin-bot melvin-bot bot changed the title Track - Workspace list doesn't show up when categorizing track expense [$250] Track - Workspace list doesn't show up when categorizing track expense Nov 28, 2024
Copy link

melvin-bot bot commented Nov 28, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021862235357007622822

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 28, 2024
Copy link

melvin-bot bot commented Nov 28, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

@nkdengineer
Copy link
Contributor

It's expected here #52253

@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors labels Nov 28, 2024
@mountiny
Copy link
Contributor

Yea based on the instructions from the issue this is expected cc @trjExpensify can you please double check and close it so? Thanks

@trjExpensify
Copy link
Contributor

Yes, no workspace list anymore. But @nkdengineer, going back shouldn't then show the list of workspaces. I think we should address that.

Copy link

melvin-bot bot commented Dec 2, 2024

@flodnv, @rushatgabhane Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Dec 2, 2024
@mountiny mountiny assigned Ollyws and nkdengineer and unassigned rushatgabhane Dec 2, 2024
@melvin-bot melvin-bot bot removed the Overdue label Dec 2, 2024
Copy link

melvin-bot bot commented Dec 2, 2024

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@mountiny
Copy link
Contributor

mountiny commented Dec 2, 2024

Assigned the C and C+ from the PR that changed it, @nkdengineer could you please follow up to implement the behaviour that Tom mentioned?

@melvin-bot melvin-bot bot added the Awaiting Payment Auto-added when associated PR is deployed to production label Dec 13, 2024
@melvin-bot melvin-bot bot changed the title [$250] Track - Workspace list doesn't show up when categorizing track expense [HOLD for payment 2024-12-20] [$250] Track - Workspace list doesn't show up when categorizing track expense Dec 13, 2024
Copy link

melvin-bot bot commented Dec 13, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 13, 2024
Copy link

melvin-bot bot commented Dec 13, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.75-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-20. 🎊

For reference, here are some details about the assignees on this issue:

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 20, 2024
Copy link

melvin-bot bot commented Dec 20, 2024

Issue is ready for payment but no BZ is assigned. @kadiealexander you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Dec 23, 2024
Copy link

melvin-bot bot commented Dec 23, 2024

@flodnv, @Ollyws, @kadiealexander, @nkdengineer Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Dec 25, 2024

@flodnv, @Ollyws, @kadiealexander, @nkdengineer Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented Dec 27, 2024

@flodnv, @Ollyws, @kadiealexander, @nkdengineer 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@jliexpensify
Copy link
Contributor

Looks like Kadie is now OOO so I can take over.

@Ollyws - do we need a checklist?

@jliexpensify
Copy link
Contributor

jliexpensify commented Dec 30, 2024

Payment Summary:

Upwork job

@jliexpensify
Copy link
Contributor

Sorry before I do anything - can someone (maybe @mountiny) confirm that this needs payment? I assume yes, since @nkdengineer implemented some new behaviours.

Copy link

melvin-bot bot commented Dec 30, 2024

@flodnv, @Ollyws, @jliexpensify, @nkdengineer Whoops! This issue is 2 days overdue. Let's get this updated quick!

@nkdengineer
Copy link
Contributor

@trjExpensify Can you confirm this comment? cc @mountiny

Copy link

melvin-bot bot commented Dec 31, 2024

@flodnv, @Ollyws, @jliexpensify, @nkdengineer Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Jan 3, 2025

@flodnv, @Ollyws, @jliexpensify, @nkdengineer 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@jliexpensify
Copy link
Contributor

@mountiny Hi, sorry just bumping again - does this require payment, or is it part of a larger job (and therefore will be paid out in that job)?

Copy link

melvin-bot bot commented Jan 7, 2025

@flodnv, @Ollyws, @jliexpensify, @nkdengineer 10 days overdue. Is anyone even seeing these? Hello?

@mountiny
Copy link
Contributor

mountiny commented Jan 7, 2025

This was just a follow-up to the previous PR with one case we did not handle well originally so no payment

@mountiny mountiny closed this as completed Jan 7, 2025
@melvin-bot melvin-bot bot removed the Overdue label Jan 7, 2025
@jliexpensify
Copy link
Contributor

Thanks @mountiny!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

9 participants