-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-12-20] [$250] Track - Workspace list doesn't show up when categorizing track expense #53274
Comments
Triggered auto assignment to @flodnv ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Job added to Upwork: https://www.upwork.com/jobs/~021862235357007622822 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane ( |
It's expected here #52253 |
Yea based on the instructions from the issue this is expected cc @trjExpensify can you please double check and close it so? Thanks |
Yes, no workspace list anymore. But @nkdengineer, going back shouldn't then show the list of workspaces. I think we should address that. |
@flodnv, @rushatgabhane Whoops! This issue is 2 days overdue. Let's get this updated quick! |
📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
Assigned the C and C+ from the PR that changed it, @nkdengineer could you please follow up to implement the behaviour that Tom mentioned? |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.75-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-12-20. 🎊 For reference, here are some details about the assignees on this issue:
|
Issue is ready for payment but no BZ is assigned. @kadiealexander you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks! |
@flodnv, @Ollyws, @kadiealexander, @nkdengineer Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@flodnv, @Ollyws, @kadiealexander, @nkdengineer Eep! 4 days overdue now. Issues have feelings too... |
@flodnv, @Ollyws, @kadiealexander, @nkdengineer 6 days overdue. This is scarier than being forced to listen to Vogon poetry! |
Looks like Kadie is now OOO so I can take over. @Ollyws - do we need a checklist? |
Payment Summary:
|
Sorry before I do anything - can someone (maybe @mountiny) confirm that this needs payment? I assume yes, since @nkdengineer implemented some new behaviours. |
@flodnv, @Ollyws, @jliexpensify, @nkdengineer Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@trjExpensify Can you confirm this comment? cc @mountiny |
@flodnv, @Ollyws, @jliexpensify, @nkdengineer Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@flodnv, @Ollyws, @jliexpensify, @nkdengineer 6 days overdue. This is scarier than being forced to listen to Vogon poetry! |
@mountiny Hi, sorry just bumping again - does this require payment, or is it part of a larger job (and therefore will be paid out in that job)? |
@flodnv, @Ollyws, @jliexpensify, @nkdengineer 10 days overdue. Is anyone even seeing these? Hello? |
This was just a follow-up to the previous PR with one case we did not handle well originally so no payment |
Thanks @mountiny! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.68-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: #52737
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Action Performed:
Pre condition: Have multiple workspaces
Expected Result:
When categorizing it workspace list should show up for the user to select from
Actual Result:
No workspace list shows up on step 4 but category list shows up, then on step 6 workspace list shows up when going back
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6679353_1732817436655.bandicam_2024-11-28_21-05-54-589.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @flodnvThe text was updated successfully, but these errors were encountered: