[Due for payment 2025-02-18] [$500] In the full story user not redirected to #admins Room After Creating Workspace – Stuck in Concierge

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation (hyperlinked to channel name): convert

Action Performed:

1. Choose an accounting package during onboarding
2. Observe that a workspace is created, and the #admins room appears.
3. Note that the user is not redirected to the #admins room automatically.
4. The user remains in the Concierge chat unless they manually navigate to the #admins room.

Expected Result:

Once the workspace is created and the #admins room appears, the user should be automatically redirected to the #admins room for a smoother experience.

Actual Result:

The user remains in the Concierge chat even after the workspace creation, requiring them to find and navigate to the #admins room manually.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Link to Fullstory is in OP

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021880331139770557066
• Upwork Job ID: 1880331139770557066
• Last Price Increase: 2025-01-17
• Automatic offers:
• DylanDylann | Reviewer | 105808765
• mkzie2 | Contributor | 105808769

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The user remains in the Concierge chat even after the workspace creation, requiring them to find and navigate to the #admins room manually.

What is the root cause of that problem?

We navigate to Concierge chat, or last accessed report after onboarding, and forcefully block navigate to workspace chats:

App/src/libs/navigateAfterOnboarding.ts

Lines 16 to 21 in 6f1541c

	const lastAccessedReport = ReportUtils.findLastAccessedReport(!canUseDefaultRooms, shouldOpenOnAdminRoom(), activeWorkspaceID);
	const lastAccessedReportID = lastAccessedReport?.reportID;
	// we don't want to navigate to newly creaded workspace after onboarding completed.
	if (!lastAccessedReportID || lastAccessedReport.policyID === onboardingPolicyID || ReportUtils.isConciergeChatReport(lastAccessedReport)) {
	return;
	}

What changes do you think we should make in order to solve the problem?

I think the main problem here is that #admins room is missing from LHN and user cannot find it causing confusions. Concierge chat already has all the necessary setup suggestions to begin with:

However I still propose 2 solutions:

1. Navigate directly to #admins room after choosing the integrated accounting solution (Manage my team's expense onboarding choice)
2. Show #admins room in LHN (my recommendation)

Navigate to #admins room instead of Concierge

Introduce a new param shouldOpenAdminRoom to this function

App/src/libs/navigateAfterOnboarding.ts

Line 6 in 6f1541c

const navigateAfterOnboarding = (isSmallScreenWidth: boolean, canUseDefaultRooms: boolean | undefined, onboardingPolicyID?: string, activeWorkspaceID?: string) => {

And when we find the last access report here, pass the above param to find the admin room:

App/src/libs/navigateAfterOnboarding.ts

Line 16 in 6f1541c

const lastAccessedReport = ReportUtils.findLastAccessedReport(!canUseDefaultRooms, shouldOpenOnAdminRoom(), activeWorkspaceID);

shouldOpenAdminRoom ?? shouldOpenOnAdminRoom()

And pass shouldOpenAdminRoom as true in BaseOnboardingAccounting:

App/src/pages/OnboardingAccounting/BaseOnboardingAccounting.tsx

Line 185 in a0afb37

navigateAfterOnboarding(isSmallScreenWidth, shouldUseNarrowLayout, canUseDefaultRooms, onboardingPolicyID, activeWorkspaceID, route.params?.backTo);

Show #admins room in LHN

Modify the shouldAdminRoomsBeVisible here to include this condition:

App/src/libs/ReportUtils.ts

Line 6673 in 5133090

function shouldAdminsRoomBeVisible(report: OnyxEntry<Report>): boolean {

if (onboardingPurposeSelected === 'newDotManageTeam' && getActiveAdminWorkspaces(allPolicies, currentUserEmail).length === 1) {
    return true;
}

So that if it was the only #admins room and the onboarding choice was Manage my team's expenses, we would show it.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

N/A

[DylanDylann]

I can reproduce this issue. Should I take over this issue as C+ as mentioned here

the correct steps:

1. Login with new Account
2. Waiting for the Onboarding modal appears
3. Select "Manage my team..." and complete the flow

Screen.Recording.2025-01-16.at.15.59.48.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021880331139770557066

[melvin-bot]

Current assignee @DylanDylann is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Upwork job price has been updated to $500

[danielrvidal]

@DylanDylann please take this over as C+. I increased the amount to $500 because we need this done urgently. Please evaluate the proposals and have fix reviewed, tested, and out by Monday if you can.

This is hitting all or at least a lot of our leads.

[Shahidullah-Muffakir]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When user selects "Manage my team's expenses' in the onboarding flow, after completing the onboarding flow, user is not landing on the Admin room.

What is the root cause of that problem?

During testing, it seems that after onboarding is completed:

1. Only the Concierge chat is displayed immediately.
2. The Admin room loads slightly later, after the user has already arrived on the landing screen.

What changes do you think we should make in order to solve the problem?

1. pass the the onboardingAdminsChatReportID and onboardingPurposeSelected to the navigateAfterOnboarding function in the BaseOnboardingAccounting:
   

   App/src/pages/OnboardingAccounting/BaseOnboardingAccounting.tsx

   Line 185 in 64ed6a5

   navigateAfterOnboarding(isSmallScreenWidth, canUseDefaultRooms, onboardingPolicyID, activeWorkspaceID);

2. update the navigateAfterOnboarding
   if the screen width is not small and the onboarding choice is MANAGE_TEAM, navigate directly to the Admin room after onboarding.
   

   App/src/libs/navigateAfterOnboarding.ts

   Lines 12 to 14 in 6f1541c

   	if (!isSmallScreenWidth) {
   	return;
   	}

if (!isSmallScreenWidth) {
    if (onboardingAdminsChatReportID && onboardingPurposeSelected === CONST.ONBOARDING_CHOICES.MANAGE_TEAM) {
        Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(onboardingAdminsChatReportID));
    }
    return;
}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The user remains in the Concierge chat even after the workspace creation, requiring them to find and navigate to the #admins room manually.

What is the root cause of that problem?

We do not open admin room after completing onboarding on large screens:

App/src/libs/navigateAfterOnboarding.ts

Lines 12 to 14 in 6f1541c

	if (!isSmallScreenWidth) {
	return;
	}

and either is small screens:

App/src/libs/navigateAfterOnboarding.ts

Lines 18 to 20 in 6f1541c

	// we don't want to navigate to newly creaded workspace after onboarding completed.
	if (!lastAccessedReportID || lastAccessedReport.policyID === onboardingPolicyID || ReportUtils.isConciergeChatReport(lastAccessedReport)) {
	return;

What changes do you think we should make in order to solve the problem?

I also think the main problem here is that the admin room is missing from LHN. On small screens, we currently just open the LHN; or the last access report that was previously deep-linked to. So if we want to explicitly open the admin rooms, we need to navigate it on both screen sizes.

1. Introduce shouldOpenAdminRoom and onboardingAdminsChatReportID param to navigateAfterOnboarding function

2. Navigate to onboardingAdminsChatReportID report and early return if shouldOpenAdminRoom in navigateAfterOnboarding after the dismissModal and before the isSmallScreenWidth here

3. Pass onboardingAdminsChatReportID and shouldOpenAdminRoom as true in BaseOnboardingAccounting.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Write the unit tests for navigateAfterOnboarding to include these cases:

• If onboardingPurposeSelected was Manage my team's expenses, should always open admin room
• Otherwise:
  • On large screens:
    • Open the currently active report in the central pane
  • On small screens:
    • If there's last access report that was previously deep-linked to, open it
    • Otherwise open LHN

What alternative solutions did you explore? (Optional)

NA

[DylanDylann]

Reviewing...

[DylanDylann]

Thanks, everyone.
@dominictb It seems your solution isn't working for me
Both @Shahidullah-Muffakir and @mkzie2 have the same solution (the minor difference is that @mkzie2 will bring this fix to the mobile screen). But I appreciate @mkzie2's proposal because he included unit tests for this flow that are valuable to avoid other bugs on this flow in the future.

Let's go with @mkzie2

🎀 👀 🎀 C+ Reviewed

[melvin-bot]

Triggered auto assignment to @dangrous, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Shahidullah-Muffakir]

@DylanDylann I think @mkzie2's proposal will cause a regression, on small screens, we shouldn’t open any chat (even adminRoom), the user should land in the inbox instead, Given this, I suggest selecting my proposal instead

[dangrous]

let me know what you think of ^^^ @DylanDylann - then I can review shortly!

[DylanDylann]

@dangrous

(the minor difference is that @mkzie2 will bring this fix to the mobile screen)

I already mentioned that in my review. But I think it is minor and we can modify it in the PR phase. On the other hand, @mkzie2 suggested adding a unit test for the onboarding flow, which I think is very valuable.

What do you think if we hire both contributors on this issue and split the compensation?

[Shahidullah-Muffakir]

But I think it is minor and we can modify it in the PR phase.

I don’t think the regression on small screens is minor . My proposal directly addresses the root cause and resolves it correctly. While adding unit tests is helpful, it’s a secondary improvement that can easily be implemented based on my proposed solution.(we can consider it in the PR phase)

[dangrous]

This is merged, not yet on staging

[danielrvidal]

Nice, I just tested on staging so it should get deployed later today. Thank you!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.95-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: app does not open admin room after onboarding #55654

If no regressions arise, payment will be issued on 2025-02-18. 🎊

For reference, here are some details about the assignees on this issue:

• @DylanDylann requires payment automatic offer (Reviewer)
• @mkzie2 requires payment automatic offer (Contributor)

[melvin-bot]

@DylanDylann @muttmuure @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

@dangrous @muttmuure @DylanDylann @mkzie2 this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[DylanDylann]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment:NA, it is a case wasn't considered

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Test:

1. Sign up in ND with a new account
2. Choose Manage my team's expenses > 1-10 employees > Any accounting platform

• On large screens, verify app navigates to the newly created #admins room
• On small screens, verify app navigates to LHN

Do we agree 👍 or 👎

[muttmuure]

Heading out on leave - adding auto-assigner

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[garrettmknight]

Payment summary:

• Contributor: @mkzie2 $500 via upwork
• Contributor+: @DylanDylann $500 via upwork

[garrettmknight]

Paid, closing