Send money - App freezes tapping payment button in send money flow

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Launch the app and login with expensifail account
2. Click the FAB button and select Send money
3. Enter an amount and tap Next button
4. Select an attendee from the list
5. Tap the payment selection button.

Expected Result:

User will see onfido flow

Actual Result:

Blank page displayed

Workaround:

Unknown

Platform:

Where is this issue occurring?

• iOS
• Android

Version Number:
1.1.13-0
Reproducible in staging?: Yes
Reproducible in production?: No
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5311234_Ios_0311-Freeze.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Jag96]

Interesting, the error for this one is

 ERROR  Error: Text strings must be rendered within a <Text> component.

This error is located at:
    in RCTView (at View.js:34)
    in View (at BasePopoverMenu.js:39)
    in RCTView (at View.js:34)
    in View (at BaseModal.js:129)
    in RCTView (at View.js:34)
    in View (at createAnimatedComponent.js:217)
    in AnimatedComponent (at createAnimatedComponent.js:278)
    in AnimatedComponentWrapper (at createAnimatableComponent.js:599)
    in withAnimatable(View) (created by ReactNativeModal)
    in RCTView (at View.js:34)
    in View (at AppContainer.js:107)
    in RCTView (at View.js:34)
    in View (at AppContainer.js:134)
    in AppContainer (at Modal.js:228)
    in RCTView (at View.js:34)
    in View (at Modal.js:249)
    in VirtualizedListContextResetter (at Modal.js:247)
    in RCTModalHostView (at Modal.js:234)
    in Modal (created by ReactNativeModal)
    in ReactNativeModal (at BaseModal.js:75)
    in BaseModal (at BaseModal.js:152)

I initially started looking for PRs in the deploy checklist that added strings outside of components, but after not seeing any I found https://stackoverflow.com/a/59108109/2509962 which lead me to the problem (we also mention this in our style guide). The error is in #6139, and it seems to be happening because the default value for menuHeaderText is set to an empty string.

One way to fix this is to check _.isEmpty, another way would be to set the default prop to undefined, but in this case I'll go with our style guide recommendation of using an isEmpty check.

[roryabraham]

Sorry for the slow response on my part here, thanks for handling this @Jag96!