-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update popover menu check to use isEmpty #6201
Conversation
Adding CP staging label to fix deploy blocker |
|
Thanks, |
(cherry picked from commit 9b9f694)
🚀 Cherry-picked to staging by @roryabraham in version: 1.1.13-2 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
@roryabraham As long as page is not freezing and user is redirected to Onfido flow its a pass right? We do not see the "Pay with expensify" option in some cases. Image.from.iOS.4.mp4 |
@mvtglobally That looks like a pass to me 👍 |
There are several accessibility issues with the Payment Options button and the overlay it opens:
|
🚀 Deployed to production by @yuwenmemon in version: 1.1.13-2 🚀
|
🚀 Deployed to staging by @roryabraham in version: 1.1.13-3 🚀
|
cc @parasharrajat
Details
This PR fixes an issue where an empty string value used in a conditional render results in a mobile crash. The explanation of why this happens and why this is my recommended fix can be found in #6198 (comment).
Fixed Issues
$ #6198
Tests/QA
Tested On
Screenshots