Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password setup - Password field is cleared when refocussing again to enter a numeral #7029

Closed
kavimuru opened this issue Jan 4, 2022 · 4 comments
Assignees

Comments

@kavimuru
Copy link

kavimuru commented Jan 4, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue was found when executing #6905

Action Performed:

  1. Launch the app
  2. Enter a new email address
  3. Click the link from the email
  4. Enter asdfasdF in password field
  5. Remove focus from the field
  6. Again focus on the field to add a number

Expected Result:

Already typed characters should appear and able to add a number

Actual Result:

The field is cleared

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • iOS

  • Mobile Web Safari

Version Number:
1.1.25 -0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

20220104.165218-1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

@MelvinBot
Copy link

Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@dklymenk
Copy link
Contributor

dklymenk commented Jan 5, 2022

I wasn't able to reproduce the issue on mWeb with safari, but I was able to reproduce it with core react native TextInput. Simply adding secureTextEntry prop causes this behaviour to occur. I have also downloaded a few apps and from the store and noticed that a lot of apps - instagram, facebook, spotify, tiktok, snapchat, pokemon go - all have this issue. The list includes both react apps and native apps, so it doesn't seem like a react native only issue. The only apps that didn't have this issue are Upwork and Waze. Not sure how upwork solved this issue, but Waze has a workaround that makes it so the input field never looses focus, which is probably not applicable to our app since we have that password toggle button.

So my question is if you would be looking for some workaround in javascript or just scrap the issue?

@MariaHCD
Copy link
Contributor

MariaHCD commented Jan 5, 2022

Thanks for the input, @dklymenk! Looks like this is the default behaviour on iOS when the property secureTextEntry is set. facebook/react-native#9148

I'm inclined toward scrapping this issue as it seems like it has a limited user impact and trying to find a workaround might be more effort than it's worth. Getting a second opinion here!

@MariaHCD
Copy link
Contributor

MariaHCD commented Jan 5, 2022

Got a second opinion from @Beamanator, we both agree that since this is standard behavior on iOS, it wouldn't be worth trying to fix this. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants