Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix password input hint stylings #6905

Merged

Conversation

anthony-hull
Copy link
Contributor

@anthony-hull anthony-hull commented Dec 27, 2021

Details

Harmonises stylings of hint text when in neutral and error state

Fixed Issues

$ #6825

QA Steps

  1. Create a new account
  2. Click link in email
  3. Enter asdfasdF
  4. Remove focus from input
  5. See hint text changes to red and shows an error
  6. Click back into the password input and enter 1
  7. See hint text changes back to grey stylings, but it doesn't shift
  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

27.12.2021_17.27.13.mp4

Mobile Web

27.12.2021_17.52.55.mp4

Desktop

Screen.Recording.2021-12-27.at.18.00.16.mov

iOS

Screen.Recording.2021-12-30.at.16.53.56.mov

Android

Screen.Recording.2021-12-28.at.23.32.21.mov

@anthony-hull anthony-hull requested a review from a team as a code owner December 27, 2021 18:17
@MelvinBot MelvinBot requested review from Beamanator and parasharrajat and removed request for a team December 27, 2021 18:17
@anthony-hull
Copy link
Contributor Author

Suggestions on how to test on iOS and Android for this?
The app crashes when I click debug in the RN debugger menu. Without this I can't use the console to:
this.document.location = "http://localhost:8080/setpassword/4562750/xxx"

Do we need to test on all platforms for such a simple CSS change?

@parasharrajat
Copy link
Member

As UI change affect each platform, yes you are required to test it on all even if it's a small change.

Please use Flipper to test it and I not sure why do you need a debugger for this change?

@anthony-hull
Copy link
Contributor Author

I need to navigate to the setPassword URL from the email in the app

@parasharrajat
Copy link
Member

Waiting for tests to be done on all platforms....

@anthony-hull
Copy link
Contributor Author

I'll have the screen recording of iOS done tomorrow

@Beamanator
Copy link
Contributor

@parasharrajat looks like tests passed, mind giving this a review before I do? ;)

@parasharrajat
Copy link
Member

Sure, I was just waiting for videos of all platforms.

@anthony-hull
Copy link
Contributor Author

I've uploaded the iOS test video. There is a bug shown in iOS when the screen res is low. I've not reported it yet.

Copy link
Member

@parasharrajat parasharrajat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Beamanator Beamanator merged commit 615f5b3 into Expensify:main Dec 31, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Jan 4, 2022

🚀 Deployed to staging by @Beamanator in version: 1.1.24-19 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 failure ❌

@OSBotify
Copy link
Contributor

OSBotify commented Jan 4, 2022

🚀 Deployed to production by @francoisl in version: 1.1.24-19 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants