-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix password input hint stylings #6905
fix password input hint stylings #6905
Conversation
Suggestions on how to test on iOS and Android for this? Do we need to test on all platforms for such a simple CSS change? |
As UI change affect each platform, yes you are required to test it on all even if it's a small change. Please use Flipper to test it and I not sure why do you need a debugger for this change? |
I need to navigate to the setPassword URL from the email in the app |
Waiting for tests to be done on all platforms.... |
I'll have the screen recording of iOS done tomorrow |
@parasharrajat looks like tests passed, mind giving this a review before I do? ;) |
Sure, I was just waiting for videos of all platforms. |
I've uploaded the iOS test video. There is a bug shown in iOS when the screen res is low. I've not reported it yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @Beamanator in version: 1.1.24-19 🚀
|
🚀 Deployed to production by @francoisl in version: 1.1.24-19 🚀
|
Details
Harmonises stylings of hint text when in neutral and error state
Fixed Issues
$ #6825
QA Steps
Screenshots
Web
27.12.2021_17.27.13.mp4
Mobile Web
27.12.2021_17.52.55.mp4
Desktop
Screen.Recording.2021-12-27.at.18.00.16.mov
iOS
Screen.Recording.2021-12-30.at.16.53.56.mov
Android
Screen.Recording.2021-12-28.at.23.32.21.mov