Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop app size is 161 Mb instead 90 Mb #8014

Closed
kavimuru opened this issue Mar 5, 2022 · 11 comments
Closed

Desktop app size is 161 Mb instead 90 Mb #8014

kavimuru opened this issue Mar 5, 2022 · 11 comments
Assignees

Comments

@kavimuru
Copy link

kavimuru commented Mar 5, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue found when executing #7744

Action Performed:

  1. Download the Desktop app .dmg and verify the size

Expected Result:

The size is close to 90 Mb

Actual Result:

The size .dmg is 161 Mb instead 90 Mb.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Desktop App

Version Number: v1.1.41-4
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Bug5478811_Screen_Shot_2022-03-04_at_4 28 02_PM

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

@MelvinBot
Copy link

Triggered auto assignment to @Beamanator (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Beamanator
Copy link
Contributor

@kidroca it looks like in the test steps of your PR (#7744), you mentioned:

Download the Desktop app .dmg and verify the size is close to 90 Mb instead of 334Mb

However, when downloading I see the app as 154mb - do you think this is "close enough" to 90mb or is something else included that needs to be removed?

@MelvinBot MelvinBot removed the Overdue label Mar 7, 2022
@francoisl
Copy link
Contributor

154 MB doesn't sound close enough to 90MB.

I'm thinking this might have had to do with #7987, which is now resolved. When I download the staging app now, its size is 91MB as expected, but it shows as an unsupported app and I can't install it at all.

image

@francoisl francoisl added the DeployBlockerCash This issue or pull request should block deployment label Mar 7, 2022
@OSBotify
Copy link
Contributor

OSBotify commented Mar 7, 2022

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@github-actions github-actions bot added Hourly KSv2 and removed Daily KSv2 labels Mar 7, 2022
@Beamanator
Copy link
Contributor

Yeah good call that does look related - @roryabraham can you help with this issue?

@Beamanator
Copy link
Contributor

Beamanator commented Mar 7, 2022

@francoisl which download link are you using for the staging app? I used https://staging.new.expensify.com/NewExpensify.dmg and I'm currently seeing a 154 MB app downloading - i'll try running it once it downloads

Update: I'm able to open it, no problem 🤔 - I think we can remove DeployBlockerCash but I'm very curious to know why it's not working for you

@kidroca
Copy link
Contributor

kidroca commented Mar 7, 2022

@Beamanator
Sorry the requirements should have been updated

We had some problems getting the app on staging and updating after #7744

@roryabraham made some updates to fix the deploy blocker and have things more close to how they used to be

This resulted in the universal app being served at https://staging.new.expensify.com/NewExpensify.dmg
Current we serve only 1 architecture

  • NewExpensify.dmg and it happens to be the universal app which is 2x size to support both x64 and arm64 (160MB installer, 350MB installed)

But we can also serve:

  • NewExpensify-x64.dmg That's the version served in the past. It works on arm64 through Rosetta (90MB installer, 200MB installed)
  • NewExpensify-arm64.dmg. This version works natively on M1 macs (90MB installer, 200MB installed)

Sample build output for all targets:

image

@kidroca
Copy link
Contributor

kidroca commented Mar 7, 2022

This is not an issue, or at least it's not a deploy blocker
The desktop app being 161Mb is still 2x smaller than what we had in the past
There's a separate ticket handling x64/arm64 distribution

@kidroca
Copy link
Contributor

kidroca commented Mar 7, 2022

@francoisl
You can tap on "New Expensify" from the .dmg and select "Get Info" from the context menu. Check the Kind field :
Screenshot 2022-03-07 at 23 32 28

I guess M1 macs can run x64, but x64 can't run the "Apple Silicon" version
While universal works on both

@Beamanator Beamanator added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Mar 7, 2022
@Beamanator
Copy link
Contributor

Awesome thanks for the clarification @kidroca 👍 💯

I'll close this out since, as you mentioned above, the larger size is expected, and we have another ticket discussion possible options here

@francoisl
Copy link
Contributor

Ok thanks for the context!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants