No results found text is not shown when a user search a non existing currency #10023

dhairyasenjaliya · 2022-07-20T03:51:41Z

Details

Here we need one condition to check if the searched currency is available or not if available we displayed in list if not matched currency then we need to show a warning message "No results found"
In order to resolve the issue we are checking the current length of all currency objects and when it returns 0 then shows a message also if all currency objects are 0 then we are also hiding the header "ALL CURRENCIES"

Fixed Issues

$ #9981

Tests

Click the FAB icon > Send/Request money option
Press on the currency icon to navigate to the currency Selection page.
Search for any invalid currency, No value should be listed, and "No results found" is shown under the search bar.
Clear the search, and check that all options the visible again.

Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

QA Steps

Click the FAB icon > Send/Request money option
Press on the currency icon to navigate to the currency Selection page.
Search for any invalid currency, No value should be listed, and "No results found" is shown under the search bar.
Clear the search, and check that all options the visible again.

Verify that no errors appear in the JS console

Screenshots

Web

web.mov

Mobile Web

mobile.web.mp4

Desktop

Desktop.mov

iOS

iPhone.mp4

Android

android.mp4

I have read the CLA Document and I hereby sign the CLA

github-actions · 2022-07-20T03:52:01Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

dhairyasenjaliya · 2022-07-20T03:56:55Z

I have read the CLA Document and I hereby sign the CLA

mountiny · 2022-07-20T09:13:29Z

Thank you! I havent look at the code yet, Rajat will help out with that, but there was one thing which I had to fix the the PR body, this is what you had:

$ https://github.com/Expensify/App/issues/<number-of-the-issue>

Do NOT only link the issue number like this: $ #<number-of-the-issue>
--->
$ [GH_LINK](https://github.com/Expensify/App/issues/9981)

This is a common problem we have and I am on the lookout for it haha. We need the issue to be linked as $ https://github.com/Expensify/App/issues/<number-of-the-issue> so we can then correctly run our webhooks logic on this. I have updated the body as required so no worries but I am noting this for your future PRs.

And I hope there s many of them to come :)

mountiny · 2022-07-20T09:16:06Z

@dhairyasenjaliya also I have oticed you commits are not signed. I think you will need to sign them, refer to the 8th point in this guide please.

You might need to make a new branch and force push to this one as the signed commits can get quite annoying!

parasharrajat

GPG sign your commits.
Add tests.
Fix QA steps.

1. Click the FAB icon > Send/Request money option
2. Press on the currency icon to navigate to the currency Selection page.
3. Search for any invalid currency, No value should be listed, and "No results found" is shown under the search bar. 
4. Clear the search, and check that all options the visible again.

src/pages/iou/IOUCurrencySelection.js

dhairyasenjaliya · 2022-07-20T11:14:45Z

Thank you! I havent look at the code yet, Rajat will help out with that, but there was one thing which I had to fix the the PR body, this is what you had:
$ https://github.com/Expensify/App/issues/<number-of-the-issue>

Do NOT only link the issue number like this: $ #<number-of-the-issue>
--->
$ [GH_LINK](https://github.com/Expensify/App/issues/9981)
This is a common problem we have and I am on the lookout for it haha. We need the issue to be linked as $ https://github.com/Expensify/App/issues/<number-of-the-issue> so we can then correctly run our webhooks logic on this. I have updated the body as required so no worries but I am noting this for your future PRs.

And I hope there s many of them to come :)

thank you, sure noted for $ links PR

mountiny

Thanks for the changes!

src/pages/iou/IOUCurrencySelection.js

dhairyasenjaliya · 2022-07-20T12:17:14Z

GPG sign your commits.
Add tests.
Fix QA steps.

1. Click the FAB icon > Send/Request money option
2. Press on the currency icon to navigate to the currency Selection page.
3. Search for any invalid currency, No value should be listed, and "No results found" is shown under the search bar. 
4. Clear the search, and check that all options the visible again.

hello, @parasharrajat have added 1. GPG and also fixed 3.QA steps
but still figuring about 2. Add tests like what I need to add maybe any document regarding that?

mountiny · 2022-07-20T12:18:31Z

Your first commit is not signed. I think you might need to create these changes again in a new local branch and then force push to this remote branch just to make sure all is good!

dhairyasenjaliya · 2022-07-20T12:21:39Z

Your first commit is not signed. I think you might need to create these changes again in a new local branch and then force push to this remote branch just to make sure all is good!

yeah was thinking the same since its fails for very first commit

parasharrajat

LGTM. This can't be merged until you fix the QA and test steps.

cc: @mountiny

PR Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- Any functional components have the displayName property
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

parasharrajat · 2022-07-20T12:51:54Z

need to add tests that you have done to validate this solution.

I still see the same old QA steps.

dhairyasenjaliya · 2022-07-20T12:59:14Z

added tests and also updated QA

mountiny

Great! Thank you both for such a quick turnaround, that is how it should be done 💪

I have just updated the title so it is clearer and easier to follow for our QA team once in staging.

Additionally, @dhairyasenjaliya our contribution guidelines ask first time contributors to only work on one issue at a time and also wait for regressions from the first PR before they can be hired for the next one. Once you are established and we know we can rely on you, these limits are omitted. I see you have had a good proposal on another issue as well, but I just wanted to note we might need to wait for a few days just to make sure this one goes without regression in staging and then you could continue working on other issues.

Sorry for any inconvenience, I am very happy with your work here and I appreciate it, but this is just a policy we follow for everyone as it happens people just disappear when they are hired for first issue haha :D

OSBotify · 2022-07-20T13:31:25Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

dhairyasenjaliya · 2022-07-20T13:43:39Z

yeah, guidelines make sense sure noted all points :D

OSBotify · 2022-07-25T18:04:15Z

🚀 Deployed to staging by @mountiny in version: 1.1.86-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2022-08-01T22:12:03Z

🚀 Deployed to production by @yuwenmemon in version: 1.1.86-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

dhairyasenjaliya requested a review from a team as a code owner July 20, 2022 03:51

melvin-bot bot requested review from mountiny and parasharrajat and removed request for a team July 20, 2022 03:51

parasharrajat suggested changes Jul 20, 2022

View reviewed changes

src/pages/iou/IOUCurrencySelection.js Outdated Show resolved Hide resolved

src/pages/iou/IOUCurrencySelection.js Outdated Show resolved Hide resolved

mountiny reviewed Jul 20, 2022

View reviewed changes

src/pages/iou/IOUCurrencySelection.js Show resolved Hide resolved

Fixes-9981 & signed

c1417af

dhairyasenjaliya force-pushed the Fix-Issue-9981 branch from d2f3007 to c1417af Compare July 20, 2022 12:23

parasharrajat approved these changes Jul 20, 2022

View reviewed changes

mountiny changed the title ~~Proposal Issue #9981 - No results found text is not shown when a user search a non existing currency~~ No results found text is not shown when a user search a non existing currency Jul 20, 2022

mountiny approved these changes Jul 20, 2022

View reviewed changes

mountiny merged commit d9efe6b into Expensify:main Jul 20, 2022

OSBotify mentioned this pull request Jul 25, 2022

Deploy Checklist: New Expensify 2022-07-25 #10077

Closed

92 tasks

melvin-bot bot mentioned this pull request Aug 1, 2022

[HOLD for payment 2022-08-08] [$250] "No results found" text is not shown when a user search a non existing currency - reported by @thesahindia #9981

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

No results found text is not shown when a user search a non existing currency #10023

No results found text is not shown when a user search a non existing currency #10023

dhairyasenjaliya commented Jul 20, 2022 •

edited

Loading

github-actions bot commented Jul 20, 2022 •

edited

Loading

dhairyasenjaliya commented Jul 20, 2022

mountiny commented Jul 20, 2022

mountiny commented Jul 20, 2022

parasharrajat left a comment

dhairyasenjaliya commented Jul 20, 2022

mountiny left a comment

dhairyasenjaliya commented Jul 20, 2022

mountiny commented Jul 20, 2022

dhairyasenjaliya commented Jul 20, 2022

parasharrajat left a comment

parasharrajat commented Jul 20, 2022

dhairyasenjaliya commented Jul 20, 2022

mountiny left a comment

OSBotify commented Jul 20, 2022

dhairyasenjaliya commented Jul 20, 2022

OSBotify commented Jul 25, 2022

OSBotify commented Aug 1, 2022

No results found text is not shown when a user search a non existing currency #10023

No results found text is not shown when a user search a non existing currency #10023

Conversation

dhairyasenjaliya commented Jul 20, 2022 • edited Loading

Details

Fixed Issues

Tests

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

QA Steps

Screenshots

Web

Mobile Web

Desktop

iOS

Android

github-actions bot commented Jul 20, 2022 • edited Loading

dhairyasenjaliya commented Jul 20, 2022

mountiny commented Jul 20, 2022

mountiny commented Jul 20, 2022

parasharrajat left a comment

Choose a reason for hiding this comment

dhairyasenjaliya commented Jul 20, 2022

mountiny left a comment

Choose a reason for hiding this comment

dhairyasenjaliya commented Jul 20, 2022

mountiny commented Jul 20, 2022

dhairyasenjaliya commented Jul 20, 2022

parasharrajat left a comment

Choose a reason for hiding this comment

PR Reviewer Checklist

parasharrajat commented Jul 20, 2022

dhairyasenjaliya commented Jul 20, 2022

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 20, 2022

dhairyasenjaliya commented Jul 20, 2022

OSBotify commented Jul 25, 2022

OSBotify commented Aug 1, 2022

dhairyasenjaliya commented Jul 20, 2022 •

edited

Loading

github-actions bot commented Jul 20, 2022 •

edited

Loading