Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Revert #9706. Rename file to DeprecatedCustomActions.js to prevent further editing #10101

Merged
merged 2 commits into from
Jul 26, 2022

Conversation

marcaaron
Copy link
Contributor

Details

  • Renaming these files so that people will stop editing the CustomActions file.
  • We need a longer term solution for navigation issues and will track them instead of making temporary changes.

Fixed Issues

No issues

Tests

None as this is a revert.

@marcaaron marcaaron requested a review from aldo-expensify July 26, 2022 01:37
@marcaaron marcaaron self-assigned this Jul 26, 2022
@marcaaron marcaaron requested a review from a team as a code owner July 26, 2022 01:37
@melvin-bot melvin-bot bot requested review from marcochavezf and removed request for a team July 26, 2022 01:37
@marcaaron marcaaron merged commit 7ac50ce into main Jul 26, 2022
@marcaaron marcaaron deleted the marcaaron-deprecateCustomActions2 branch July 26, 2022 21:24
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Aug 1, 2022

🚀 Deployed to staging by @marcaaron in version: 1.1.87-0 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 failure ❌

@OSBotify
Copy link
Contributor

OSBotify commented Aug 4, 2022

🚀 Deployed to production by @yuwenmemon in version: 1.1.87-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants