Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Deep Links not working on Android 12+ #10128

Merged
merged 20 commits into from
Aug 15, 2022
Merged

Fix Deep Links not working on Android 12+ #10128

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
6a1741f
feat: upgrading targetSdkVersion
tomivs Jul 27, 2022
0d21e9e
feat: updating npm pkgs for new targetSdkVersion
tomivs Jul 27, 2022
33ef541
feat: android:exported for activities
tomivs Jul 27, 2022
b1ccedf
chore: adds assetlinks.json for link verification
tomivs Jul 27, 2022
e55f74d
chore: webpack config to deploy assetlinks.json
tomivs Jul 27, 2022
921bf0c
fix: removing old Swift reference
tomivs Aug 4, 2022
fa5ccf8
fix: removing old Swift reference 2
tomivs Aug 4, 2022
15f6dc4
feat: updating to [email protected]
tomivs Aug 4, 2022
93e92b1
Revert "feat: upgrading targetSdkVersion"
tomivs Aug 11, 2022
f5ecc63
Revert "feat: updating npm pkgs for new targetSdkVersion"
tomivs Aug 11, 2022
c0844c0
Revert "feat: android:exported for activities"
tomivs Aug 11, 2022
01b905e
Revert "fix: removing old Swift reference"
tomivs Aug 11, 2022
2fb9853
Revert "fix: removing old Swift reference 2"
tomivs Aug 11, 2022
99b0890
Revert "feat: updating to [email protected]"
tomivs Aug 11, 2022
c8aa9fa
Revert "feat: updating npm pkgs for new targetSdkVersion"
tomivs Aug 11, 2022
9904c07
Merge branch 'Expensify:main' into tomivs-deep-links-android-12
tomivs Aug 11, 2022
6399644
fix: set up AndroidManifest.xml for Android 12+
tomivs Aug 11, 2022
695862c
Merge branch 'Expensify:main' into tomivs-deep-links-android-12
tomivs Aug 11, 2022
1b4fa01
Merge branch 'Expensify:main' into tomivs-deep-links-android-12
tomivs Aug 11, 2022
3e01ca4
Merge branch 'Expensify:main' into tomivs-deep-links-android-12
tomivs Aug 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@ buildscript {
ext {
buildToolsVersion = "30.0.2"
minSdkVersion = 21
compileSdkVersion = 31
targetSdkVersion = 31
compileSdkVersion = 30
targetSdkVersion = 30
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we need 31 for Android 12

Copy link
Contributor Author

@tomivs tomivs Aug 11, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

targetSdkVersion = 31 is necessary and is already in main. It seems like here you're suggesting to change it to 30?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad this is an old commit. All good on this.

androidXCore = "1.0.2"
multiDexEnabled = true
googlePlayServicesVersion = "17.0.0"
kotlinVersion = '1.6.0'
kotlinVersion = '1.4.21'
}
repositories {
google()
Expand Down