Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete old unused UpdateProfile param #10293

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Conversation

Beamanator
Copy link
Contributor

Removing a param that we stopped supporting in https://github.com/Expensify/Web-Expensify/pull/34450

Details

$ https://github.com/Expensify/Expensify/issues/220321

Tests

  1. Go to Settings - Profile
  2. Update a few profile items (first name, last name, pronouns, and / or timezone)
  3. Save profile
  4. Navigate away, then navigate back
  5. Repeat steps 2 - 4 a few times, making sure everything updates correctly and there's no console errors

QA Steps

  1. Go to Settings - Profile
  2. Update a few profile items (first name, last name, pronouns, and / or timezone)
  3. Save profile
  4. Navigate away, then navigate back
  5. Repeat steps 2 - 4 a few times, making sure everything updates correctly and there's no console errors

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@Beamanator Beamanator requested a review from a team as a code owner August 8, 2022 10:45
@Beamanator Beamanator self-assigned this Aug 8, 2022
@melvin-bot melvin-bot bot requested review from jasperhuangg and removed request for a team August 8, 2022 10:46
@jasperhuangg
Copy link
Contributor

Looks like https://github.com/Expensify/Web-Expensify/pull/34450 was deployed to production, so I'm gonna take the hold off

@jasperhuangg jasperhuangg changed the title [HOLD Web-E#34450] Delete old unused UpdateProfile param Delete old unused UpdateProfile param Aug 10, 2022
@jasperhuangg jasperhuangg merged commit 521102a into main Aug 10, 2022
@jasperhuangg jasperhuangg deleted the beaman-cleanupOldParam branch August 10, 2022 16:54
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@Beamanator
Copy link
Contributor Author

Nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants