fix: alter expensify-datepicker class #13316

shonsirsha · 2022-12-04T17:39:51Z

Details

When date picker is visible (normally on desktop app & desktop web), date picker icon should be centred (vertically) and its touchable/clickable area should be increased.

Fixed Issues

$ 12957
PROPOSAL: GH_LINK_ISSUE (COMMENT) - a super slight modification of it.

Tests

Go to any view with a date picker, for example: Workspace -> Connect Bank Account -> Connect Manual -> Company Step -> Incorporation date
If Icon is visible, it should be in the centre (vertically)
If Icon is visible, it should still be clickable even when not clicking exactly on it (has a sufficient surface / touchable / clickable area). Upon successful click, it opens the datepicker dialogue.

Verify that no errors appear in the JS console

Offline tests

Turn network to offline
Go to any view with a date picker that's available offline
If Icon is visible, it should be in the centre (vertically)
If Icon is visible, it should still be clickable even when not clicking exactly on it (has a sufficient surface / touchable / clickable area). Upon successful click, it opens the datepicker dialogue.

QA Steps

Go to any view with a date picker, for example: Workspace -> Connect Bank Account -> Connect Manual -> Company Step -> Incorporation date
If Icon is visible, it should be in the centre (vertically)
Icon is still clickable which opens the date dialogue even when not clicking exactly on it (has a sufficient surface / touchable / clickable area).

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2022-12-04.at.17.34.13.mov

Mobile Web - Chrome

Screen.Recording.2022-12-04.at.18.50.04.mov

Mobile Web - Safari

MWEB.MP4

Desktop

Screen.Recording.2022-12-04.at.18.24.33.mov

iOS

Screen.Recording.2022-12-05.at.05.33.41.mov

Android

Screen.Recording.2022-12-04.at.18.54.15.mov

melvin-bot · 2022-12-04T17:39:54Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

github-actions · 2022-12-04T17:40:07Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

melvin-bot · 2022-12-04T17:40:23Z

@deetergp Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

sobitneupane · 2022-12-05T03:17:26Z

src/components/DatePicker/styles.css

    color-scheme: dark;
+    cursor: pointer;
+    padding: 18px 13px;


Can you please update padding to address this comment.

sobitneupane

Screen Recording is missing for IOS in PR body. Can you please update it to include screen recording for IOS as well.

shonsirsha · 2022-12-05T04:16:12Z

@sobitneupane Thanks for the comments, changes addressed. PTAL 🙏

I also altered the font size (calendar icon's size) to be the same as the other icons - as it was around 5-6px smaller before.

If we keep the icon smaller than the others, combined with the padding that we have right now (18px 9px, which made it align nicely to the right) it's gonna look odd (too much whitespace on left side).

Thus, I increased the size of the calendar icon - so all icons have a uniform size. Thanks.

sobitneupane · 2022-12-05T05:07:24Z

@shonsirsha There are different factors that determine the font size of elements. So, comparing in one platform and using a value is not the right option. Let's not change the font size.

shonsirsha · 2022-12-05T05:49:25Z

@shonsirsha There are different factors that determine the font size of elements. So, comparing in one platform and using a value is not the right option. Let's not change the font size.

Hi, sure! 🙂 reverted

shonsirsha · 2022-12-05T11:43:53Z

Oops, I re-requested review and it automatically removed @deetergp from the reviewers list. Please feel free to add yourself in again if it's necessary (as I can't do so atm). Thanks!

shonsirsha · 2022-12-06T08:58:10Z

Hey, sorry for spamming but do we have any updates here? 🙂 Please lmk if I'm missing something, thanks.

sobitneupane · 2022-12-06T12:59:26Z

src/components/DatePicker/styles.css

    color-scheme: dark;
+    cursor: pointer;
+    padding: 18px 9px;


Suggested change

padding: 18px 9px;

padding: 18px 13px;

Looks like having 13px makes more sense. As it will be aligned to center of the dropdown pointer icons. Sorry for the confusion.

No probs! Change has been made 🙂

shonsirsha · 2022-12-06T18:20:00Z

Hey 👋 , I believe we are good here..? Any possibility to get an approval or any updates?

Sorry, it's my first PR to this repo - is something else needs to be done from my side? 🙂

deetergp

Changes look good, but you need to sign the CLA @shonsirsha and @sobitneupane needs to compete the reviewer checklist in order for the tests to pass so that the PR can be merged.

deetergp · 2022-12-06T18:21:22Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

deetergp · 2022-12-06T18:23:04Z

Actually, it looks like it's on me to complete the checklist, so I'll do so now.

shonsirsha · 2022-12-06T18:46:04Z

I have read the CLA Document and I hereby sign the CLA

shonsirsha · 2022-12-06T18:51:09Z

Thanks a lot @deetergp! Seems like like I have sucessfully signed the CLA.

The check in this PR is still failing though. How does one re-run this check?

deetergp · 2022-12-06T20:10:37Z

Okay, all the tests are passing. All that's left now is for @sobitneupane to approve.

sobitneupane

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

sobitneupane · 2022-12-07T03:48:43Z

Changes look good and test well.

🎀👀🎀 C+ reviewed

cc: @deetergp @grgia

OSBotify · 2022-12-07T19:09:50Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-12-13T22:39:08Z

🚀 Deployed to production by @chiragsalian in version: 1.2.38-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

shonsirsha requested a review from a team as a code owner December 4, 2022 17:39

melvin-bot bot requested review from deetergp and removed request for a team December 4, 2022 17:40

shonsirsha force-pushed the fix/date-picker-icon-not-centred branch from 47f3e00 to b690ab8 Compare December 4, 2022 18:05

sobitneupane reviewed Dec 5, 2022

View reviewed changes

shonsirsha force-pushed the fix/date-picker-icon-not-centred branch from b690ab8 to 3d9af3d Compare December 5, 2022 04:15

shonsirsha force-pushed the fix/date-picker-icon-not-centred branch from 3d9af3d to 9e3a17d Compare December 5, 2022 05:48

shonsirsha requested review from sobitneupane and removed request for deetergp December 5, 2022 11:40

deetergp self-requested a review December 5, 2022 22:59

sobitneupane reviewed Dec 6, 2022

View reviewed changes

fix: alter expensify-datepicker class

c87353e

shonsirsha force-pushed the fix/date-picker-icon-not-centred branch from 9e3a17d to c87353e Compare December 6, 2022 13:15

deetergp approved these changes Dec 6, 2022

View reviewed changes

sobitneupane approved these changes Dec 7, 2022

View reviewed changes

deetergp merged commit 41a099b into Expensify:main Dec 7, 2022

francoisl mentioned this pull request Dec 8, 2022

Deploy Checklist: New Expensify 2022-12-07 #13431

Closed

72 tasks

sobitneupane mentioned this pull request Dec 14, 2022

[$1000] Date picker is not centered and has too small clickable area #12957

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: alter expensify-datepicker class #13316

fix: alter expensify-datepicker class #13316

shonsirsha commented Dec 4, 2022 •

edited

Loading

melvin-bot bot commented Dec 4, 2022

github-actions bot commented Dec 4, 2022 •

edited

Loading

melvin-bot bot commented Dec 4, 2022

sobitneupane Dec 5, 2022

sobitneupane left a comment

shonsirsha commented Dec 5, 2022

sobitneupane commented Dec 5, 2022 •

edited

Loading

shonsirsha commented Dec 5, 2022

shonsirsha commented Dec 5, 2022 •

edited

Loading

shonsirsha commented Dec 6, 2022

sobitneupane Dec 6, 2022

sobitneupane Dec 6, 2022 •

edited

Loading

shonsirsha Dec 6, 2022 •

edited

Loading

shonsirsha commented Dec 6, 2022

deetergp left a comment

deetergp commented Dec 6, 2022 •

edited

Loading

deetergp commented Dec 6, 2022

shonsirsha commented Dec 6, 2022

shonsirsha commented Dec 6, 2022

deetergp commented Dec 6, 2022

sobitneupane left a comment

sobitneupane commented Dec 7, 2022

OSBotify commented Dec 7, 2022

OSBotify commented Dec 13, 2022

fix: alter expensify-datepicker class #13316

fix: alter expensify-datepicker class #13316

Conversation

shonsirsha commented Dec 4, 2022 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 4, 2022

github-actions bot commented Dec 4, 2022 • edited Loading

melvin-bot bot commented Dec 4, 2022

sobitneupane Dec 5, 2022

Choose a reason for hiding this comment

sobitneupane left a comment

Choose a reason for hiding this comment

shonsirsha commented Dec 5, 2022

sobitneupane commented Dec 5, 2022 • edited Loading

shonsirsha commented Dec 5, 2022

shonsirsha commented Dec 5, 2022 • edited Loading

shonsirsha commented Dec 6, 2022

sobitneupane Dec 6, 2022

Choose a reason for hiding this comment

sobitneupane Dec 6, 2022 • edited Loading

Choose a reason for hiding this comment

shonsirsha Dec 6, 2022 • edited Loading

Choose a reason for hiding this comment

shonsirsha commented Dec 6, 2022

deetergp left a comment

Choose a reason for hiding this comment

deetergp commented Dec 6, 2022 • edited Loading

Reviewer Checklist

Screenshots/Videos

deetergp commented Dec 6, 2022

shonsirsha commented Dec 6, 2022

shonsirsha commented Dec 6, 2022

deetergp commented Dec 6, 2022

sobitneupane left a comment

Choose a reason for hiding this comment

Screenshots/Videos

sobitneupane commented Dec 7, 2022

OSBotify commented Dec 7, 2022

OSBotify commented Dec 13, 2022

shonsirsha commented Dec 4, 2022 •

edited

Loading

github-actions bot commented Dec 4, 2022 •

edited

Loading

sobitneupane commented Dec 5, 2022 •

edited

Loading

shonsirsha commented Dec 5, 2022 •

edited

Loading

sobitneupane Dec 6, 2022 •

edited

Loading

shonsirsha Dec 6, 2022 •

edited

Loading

deetergp commented Dec 6, 2022 •

edited

Loading