Fix - “Submitted $amount” system message appears for a moment when Employee submit IOU #39321

FitseTLT · 2024-03-30T17:25:09Z

Details

Fixed Issues

$ #38579
PROPOSAL: #38579 (comment)

Tests

Go to https://staging.new.expensify.com/
Log in as Employee of a Collect WS
Open WS chat and request a money
Open IOU and press Submit button in the header
Verify that the submitted system message is in the form of You submitted this report to ... same as what the server returns (the system message shouldn't change after a while which happens on current main when the message is loaded from the server)
Again create a request as an employee
And this time submit it from the admin side
Verify that the submitted system message is in the form of You ( on behalf of ... same as what the server returns

Verify that no errors appear in the JS console

Offline tests

same as Tests

QA Steps

same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

2024-03-30.20-23-51.mp4

Android: mWeb Chrome

and.web.mp4

an.we.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

ios.web.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desk.mp4

melvin-bot · 2024-03-30T17:25:14Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hungvu193 · 2024-04-01T16:41:52Z

Will review in my morning time.

src/libs/ReportUtils.ts

hungvu193 · 2024-04-02T02:13:22Z

Note that, IOU preview is broken, it doesn't relate to this PR. It was reported here

Screen.Recording.2024-04-02.at.09.11.20.mov

hungvu193 · 2024-04-02T06:29:07Z

src/libs/ReportUtils.ts

+        } else {
+            submittedToDisplayName = ownerPersonalDetails?.displayName
+                ? `${ownerPersonalDetails.displayName}${ownerPersonalDetails.displayName !== ownerPersonalDetails.login ? ` (${ownerPersonalDetails.login})` : ''}`
+                : 'Hidden';


Can you provide the tests for Hidden case?

Nope. I just thought it would be better to have submitted to Hidden rather than submitted To. The case could happen if the personal details list is not ready in onyx but I couldn't reproduce the case honestly.

I think once user got invited to workspace, they will be ready in Onyx because we will get these information while opening the App.

src/libs/ReportUtils.ts

hungvu193 · 2024-04-02T09:51:52Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

mwebchrome.mov

Screen.Recording.2024-04-16.at.22.24.06.mov

iOS: Native

Screen.Recording.2024-04-03.at.09.54.33.mov

iOS: mWeb Safari

Screen.Recording.2024-04-03.at.09.32.35.mov

MacOS: Chrome / Safari

chrome.mov

Screen.Recording.2024-04-16.at.22.21.11.mov

MacOS: Desktop

desk.mov

hungvu193 · 2024-04-02T09:52:44Z

@FitseTLT Please update Offline and QA steps as well.

hungvu193 · 2024-04-02T11:07:23Z

@FitseTLT The code looks good, don't forget to update the QA and Offline steps, so I can complete the checklist. Thank you

FitseTLT · 2024-04-02T11:08:47Z

@FitseTLT The code looks good, don't forget to update the QA and Offline steps, so I can complete the checklist. Thank you

updated

hungvu193 · 2024-04-02T11:10:02Z

@FitseTLT The code looks good, don't forget to update the QA and Offline steps, so I can complete the checklist. Thank you

updated

I'm sorry but you need to update it as Same as Tests or Same as above.

FitseTLT · 2024-04-02T11:15:20Z

@FitseTLT The code looks good, don't forget to update the QA and Offline steps, so I can complete the checklist. Thank you

updated

I'm sorry but you need to update it as Same as Tests or Same as above.

done

hungvu193

LGTM!

FitseTLT · 2024-04-12T08:32:26Z

No worries, let's try it and let me know the result.

@FitseTLT any updates here please?

It is working perfectly for me @hungvu193

hungvu193 · 2024-04-12T08:33:58Z

No worries, let's try it and let me know the result.

@FitseTLT any updates here please?

It is working perfectly for me @hungvu193

Thank you.
@pecanoro Can you also give it a try? Should be something wrong from my end

pecanoro · 2024-04-16T10:09:41Z

What is the action we are having trouble testing? Submitting from the admin side?

hungvu193 · 2024-04-16T10:13:21Z

What is the action we are having trouble testing? Submitting from the admin side?

Yes. That's one

FitseTLT · 2024-04-16T10:20:01Z

What is the action we are having trouble testing? Submitting from the admin side?

I am able to submit from admin side. You have to create the request from employee side and you submit it on behalf of that employee from the admin side.

pecanoro · 2024-04-16T12:51:56Z

I tested the admin submitting the report. Submit only shows if the approver in the policy settings is set to someone else who is not the admin.

I noticed this glitch, but I am not sure where it's coming from:

Monosnap.screencast.2024-04-16.14-45-06.mp4

A different case, if the admin submits on behalf of someone else, it changes from optimistic (You (on behalf of [email protected] via admin-submit) submitted this report) to final (You (on behalf of [email protected] via admin-submit) submitted this report to [email protected])

FitseTLT · 2024-04-16T13:10:59Z

A different case, if the admin submits on behalf of someone else, it changes from optimistic (You (on behalf of [email protected] via admin-submit) submitted this report) to final (You (on behalf of [email protected] via admin-submit) submitted this report to [email protected])

From the submitter admin side the message ends with submitted this report to you and that is the only case we should worry here as we are setting optimistic message from the submitter side. The one that ends with submitted this report to <email> is from the employee side for whom the report was submitted on behalf that comes from the BE we shouldn't worry 👍

2024-04-16.16-11-35.mp4

hungvu193 · 2024-04-16T15:04:39Z

A different case, if the admin submits on behalf of someone else, it changes from optimistic (You (on behalf of [email protected] via admin-submit) submitted this report) to final (You (on behalf of [email protected] via admin-submit) submitted this report to [email protected])

From the submitter admin side the message ends with submitted this report to you and that is the only case we should worry here as we are setting optimistic message from the submitter side. The one that ends with submitted this report to <email> is from the employee side for whom the report was submitted on behalf that comes from the BE we shouldn't worry 👍

2024-04-16.16-11-35.mp4

Can you please invite me to your test workspace? My email is [email protected]. Even when I created a brand new WS. I couldn't submit it :(

FitseTLT · 2024-04-16T15:09:37Z

Done! But, out of curiosity, are u creating the workspace from ND; mine is from OD. That might be the trick

hungvu193 · 2024-04-16T15:10:34Z

Done! But, out of curiosity, are u creating the workspace from ND; mine is from OD. That might be the trick

I tried both, but let me try again!

hungvu193 · 2024-04-16T15:22:22Z

Ok, I can do it now by creating a control WS 🤦 . Sorry everyone, I will update the checklist now.

hungvu193

Updated checklist. All yours @pecanoro

pecanoro · 2024-04-17T13:03:59Z

@FitseTLT Did you check the video for that glitch with the action message changing?

FitseTLT · 2024-04-17T13:08:37Z

@FitseTLT Did you check the video for that glitch with the action message changing?

I am not experiencing that @pecanoro

2024-04-17.16-07-42.mp4

pecanoro · 2024-04-17T14:40:38Z

Let me test it again haha

pecanoro · 2024-04-18T15:18:44Z

@FitseTLT Can you merge with main? It's been a while so I want to make sure

pecanoro · 2024-04-18T16:04:32Z

I still get that weird glitch 😢 @hungvu193 Can you try doing the same to see if it's only me?

hungvu193 · 2024-04-18T16:32:35Z

I still get that weird glitch 😢 @hungvu193 Can you try doing the same to see if it's only me?

Oh, weird. It didn't seem to happen with me.

Screen.Recording.2024-04-18.at.23.31.54.mov

hungvu193 · 2024-04-18T16:41:44Z

Can you post the Onyx logs from verbose console? That would be really helpful

FitseTLT · 2024-04-19T08:01:04Z

Merged with main

hungvu193 · 2024-04-19T21:32:25Z

Little pump @pecanoro

pecanoro · 2024-04-22T12:39:43Z

Sorry, I was out of office last Friday! I am going to approve and merge since it seems I am the only one having this weird glitch 😄

OSBotify · 2024-04-23T23:42:28Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.64-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

FitseTLT added 4 commits March 30, 2024 19:00

fixed optimistic submitted report action

4e11125

fixed for no display name case

deb453c

changed to policy submitsTo

22ca301

Add submitted to oneself case

fa1a0f8

FitseTLT requested a review from a team as a code owner March 30, 2024 17:25

melvin-bot bot requested review from situchan and removed request for a team March 30, 2024 17:25

changed variable name

cfc0c8a

hungvu193 suggested changes Apr 2, 2024

View reviewed changes

src/libs/ReportUtils.ts Show resolved Hide resolved

hungvu193 suggested changes Apr 2, 2024

View reviewed changes

FitseTLT added 2 commits April 2, 2024 12:17

Merge branch 'main' into fix-submitted-optimistic-message

c88f21a

implemented it into separate function

9ce0d6b

FitseTLT requested a review from hungvu193 April 2, 2024 09:34

hungvu193 reviewed Apr 2, 2024

View reviewed changes

src/libs/ReportUtils.ts Show resolved Hide resolved

hungvu193 reviewed Apr 2, 2024

View reviewed changes

src/libs/ReportUtils.ts Outdated Show resolved Hide resolved

avoided double terniary

8103f5a

FitseTLT requested a review from hungvu193 April 2, 2024 10:03

minor fix

989ed81

hungvu193 mentioned this pull request Apr 2, 2024

[HOLD for payment 2024-05-01] [$500] Workspace – “Submitted $amount” system message appears for a moment when Employee submit IOU #38579

Closed

6 tasks

hungvu193 approved these changes Apr 3, 2024

View reviewed changes

melvin-bot bot requested a review from pecanoro April 3, 2024 02:56

Merge branch 'main' into fix-submitted-optimistic-message

1336678

hungvu193 approved these changes Apr 16, 2024

View reviewed changes

Merge branch 'main' into fix-submitted-optimistic-message

e9df81b

pecanoro approved these changes Apr 22, 2024

View reviewed changes

pecanoro merged commit a9d5bec into Expensify:main Apr 22, 2024
15 checks passed

github-actions bot mentioned this pull request Apr 22, 2024

Deploy Checklist: New Expensify 2024-04-22 #40702

Closed

95 tasks

kbecciv mentioned this pull request Apr 23, 2024

[$250] Expense - System message changes to "<you> submitted report to you" #40780

Closed

6 tasks

flodnv mentioned this pull request Jun 3, 2024

Replace policy.submitsTo with PolicyUtils.getSubmitToAccountID #40532

Merged

50 tasks

Fix - “Submitted $amount” system message appears for a moment when Employee submit IOU #39321

Fix - “Submitted $amount” system message appears for a moment when Employee submit IOU #39321

Conversation

FitseTLT commented Mar 30, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Mar 30, 2024

hungvu193 commented Apr 1, 2024

hungvu193 commented Apr 2, 2024

hungvu193 Apr 2, 2024

Choose a reason for hiding this comment

FitseTLT Apr 2, 2024

Choose a reason for hiding this comment

hungvu193 Apr 2, 2024

Choose a reason for hiding this comment

hungvu193 commented Apr 2, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

hungvu193 commented Apr 2, 2024

hungvu193 commented Apr 2, 2024

FitseTLT commented Apr 2, 2024

hungvu193 commented Apr 2, 2024

FitseTLT commented Apr 2, 2024

hungvu193 left a comment

Choose a reason for hiding this comment

FitseTLT commented Apr 12, 2024

hungvu193 commented Apr 12, 2024

pecanoro commented Apr 16, 2024

hungvu193 commented Apr 16, 2024

FitseTLT commented Apr 16, 2024

pecanoro commented Apr 16, 2024

FitseTLT commented Apr 16, 2024 • edited Loading

hungvu193 commented Apr 16, 2024

FitseTLT commented Apr 16, 2024 • edited Loading

hungvu193 commented Apr 16, 2024

hungvu193 commented Apr 16, 2024

hungvu193 left a comment

Choose a reason for hiding this comment

pecanoro commented Apr 17, 2024

FitseTLT commented Apr 17, 2024

pecanoro commented Apr 17, 2024

pecanoro commented Apr 18, 2024

pecanoro commented Apr 18, 2024

hungvu193 commented Apr 18, 2024

hungvu193 commented Apr 18, 2024

FitseTLT commented Apr 19, 2024

hungvu193 commented Apr 19, 2024

pecanoro commented Apr 22, 2024

OSBotify commented Apr 23, 2024

FitseTLT commented Mar 30, 2024 •

edited

Loading

hungvu193 commented Apr 2, 2024 •

edited

Loading

FitseTLT commented Apr 16, 2024 •

edited

Loading

FitseTLT commented Apr 16, 2024 •

edited

Loading