Fix unread message indicator not displayed after flagging message as offensive #39482

bernhardoj · 2024-04-03T10:28:26Z

Details

When we mark as unread, it will find the last action from other users including whisper action, but the report lastViisbleActionCreated doesn't include a whisper action created, except for ACTIONABLEMENTIONWHISPER.

Fixed Issues

$ #39170
PROPOSAL: #39170 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Open a chat with user B
As user B, send a message
As user A, flag the message as offensive and select spam
Wait until the concierge whisper about flagging shows
Close/switch the chat page
Right-click or long press the previous chat to open the context menu
Select mark as unread
Verify the chat in LHN is in bold
Open the chat
Verify the message that you flag has green unread indicator line

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-04-03.at.18.16.49.mov

Android: mWeb Chrome

Screen.Recording.2024-04-03.at.18.11.30.mov

iOS: Native

Screen.Recording.2024-04-03.at.18.22.08.mov

iOS: mWeb Safari

Screen.Recording.2024-04-03.at.18.18.08.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-03.at.18.09.24.mov

MacOS: Desktop

Screen.Recording.2024-04-03.at.18.09.52.mov

melvin-bot · 2024-04-03T10:28:30Z

@akinwale Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2024-04-03T10:30:08Z

Additional video shows that mark as unread works for actionable mention whisper.

Screen.Recording.2024-04-03.at.18.15.42.mov

akinwale · 2024-04-09T15:41:37Z

Reviewing today.

akinwale · 2024-04-10T14:21:15Z

@bernhardoj Please merge latest main.

…-whisper

bernhardoj · 2024-04-10T15:42:55Z

Done

akinwale · 2024-04-14T16:52:15Z

Apologies for the delay as I ran into some build issues when trying to test with new arch merged on Android. I've completed testing and review.

akinwale · 2024-04-14T16:54:15Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

39482-android-native.mp4

Android: mWeb Chrome

39482-android-chrome.mp4

iOS: Native

39482-ios-native.mp4

iOS: mWeb Safari

39482-ios-safari.mp4

MacOS: Chrome / Safari

39482-web.mp4

MacOS: Desktop

39482-desktop.mp4

akinwale

LGTM.

pecanoro · 2024-04-16T12:23:06Z

src/libs/actions/Report.ts

@@ -998,7 +998,12 @@ function markCommentAsUnread(reportID: string, reportActionCreated: string) {

    // Find the latest report actions from other users
    const latestReportActionFromOtherUsers = Object.values(reportActions ?? {}).reduce((latest: ReportAction | null, current: ReportAction) => {
-        if (current.actorAccountID !== currentUserAccountID && (!latest || current.created > latest.created)) {
+        if (
+            current.actorAccountID !== currentUserAccountID &&


The style is odd, this should go after the if not in a new line 🤔

Prettier doesn't allow me to move it after the if

There are a few codes that has the same style, for example,

App/src/pages/home/report/ReportActionsList.tsx

Lines 219 to 225 in ed7029b

useEffect(() => {

if (

scrollingVerticalOffset.current < AUTOSCROLL_TO_TOP_THRESHOLD &&

previousLastIndex.current !== lastActionIndex &&

reportActionSize.current > sortedVisibleReportActions.length &&

hasNewestReportAction

) {

Wow so ugly but sure 😄

OSBotify · 2024-04-16T13:20:43Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-18T04:56:02Z

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.4.63-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-22T14:57:01Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.63-21 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

skip whisper when mark as read except ACTIONABLEMENTIONWHISPER

3cd0cb1

bernhardoj requested a review from a team as a code owner April 3, 2024 10:28

melvin-bot bot removed the request for review from a team April 3, 2024 10:28

melvin-bot bot requested a review from akinwale April 3, 2024 10:28

Merge branch 'main' into fix/39170-mark-as-unread-when-last-action-is…

8b5871b

…-whisper

akinwale approved these changes Apr 14, 2024

View reviewed changes

melvin-bot bot requested a review from Julesssss April 14, 2024 16:54

pecanoro requested changes Apr 16, 2024

View reviewed changes

pecanoro approved these changes Apr 16, 2024

View reviewed changes

pecanoro merged commit c75c85f into Expensify:main Apr 16, 2024
22 checks passed

github-actions bot mentioned this pull request Apr 18, 2024

Deploy Checklist: New Expensify 2024-04-18 #40392

Closed

akinwale mentioned this pull request May 1, 2024

[$250] Chat - Unread message indicator not displayed after flagging message as offensive #39170

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix unread message indicator not displayed after flagging message as offensive #39482

Fix unread message indicator not displayed after flagging message as offensive #39482

bernhardoj commented Apr 3, 2024

melvin-bot bot commented Apr 3, 2024

bernhardoj commented Apr 3, 2024

akinwale commented Apr 9, 2024

akinwale commented Apr 10, 2024

bernhardoj commented Apr 10, 2024

akinwale commented Apr 14, 2024

akinwale commented Apr 14, 2024

akinwale left a comment

pecanoro Apr 16, 2024

bernhardoj Apr 16, 2024

bernhardoj Apr 16, 2024

pecanoro Apr 16, 2024

OSBotify commented Apr 16, 2024

OSBotify commented Apr 18, 2024

OSBotify commented Apr 22, 2024

	useEffect(() => {
	if (
	scrollingVerticalOffset.current < AUTOSCROLL_TO_TOP_THRESHOLD &&
	previousLastIndex.current !== lastActionIndex &&
	reportActionSize.current > sortedVisibleReportActions.length &&
	hasNewestReportAction
	) {

Fix unread message indicator not displayed after flagging message as offensive #39482

Fix unread message indicator not displayed after flagging message as offensive #39482

Conversation

bernhardoj commented Apr 3, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Apr 3, 2024

bernhardoj commented Apr 3, 2024

akinwale commented Apr 9, 2024

akinwale commented Apr 10, 2024

bernhardoj commented Apr 10, 2024

akinwale commented Apr 14, 2024

akinwale commented Apr 14, 2024

Reviewer Checklist

Screenshots/Videos

akinwale left a comment

Choose a reason for hiding this comment

pecanoro Apr 16, 2024

Choose a reason for hiding this comment

bernhardoj Apr 16, 2024

Choose a reason for hiding this comment

bernhardoj Apr 16, 2024

Choose a reason for hiding this comment

pecanoro Apr 16, 2024

Choose a reason for hiding this comment

OSBotify commented Apr 16, 2024

OSBotify commented Apr 18, 2024

OSBotify commented Apr 22, 2024