Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] Fix Flipper for Android #4317

Merged
merged 4 commits into from
Jul 30, 2021
Merged

[No QA] Fix Flipper for Android #4317

merged 4 commits into from
Jul 30, 2021

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Jul 30, 2021 •
edited
Loading

Details

Flipper was not working on Android

Fixed Issues

No Issue

Tests

  1. Build Android app on dev (use actual device if possible)
  2. Verify Flipper works.

Huh? What is Flipper?

QA Steps

None

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

❌

@marcaaron marcaaron self-assigned this Jul 30, 2021
@marcaaron marcaaron changed the title [WIP] Fix Flipper for Android [No QA] Fix Flipper for Android Jul 30, 2021
@botify
Copy link

botify commented Jul 30, 2021

npm has a package.json file and a package-lock.json file. It seems you updated one without the other, which is usually a sign of a mistake. If you are updating a package make sure that you update the version in package.json then run npm install

1 similar comment
@botify
Copy link

botify commented Jul 30, 2021

npm has a package.json file and a package-lock.json file. It seems you updated one without the other, which is usually a sign of a mistake. If you are updating a package make sure that you update the version in package.json then run npm install

@marcaaron marcaaron marked this pull request as ready for review July 30, 2021 03:36
@marcaaron marcaaron requested a review from a team as a code owner July 30, 2021 03:37
@MelvinBot MelvinBot requested review from Jag96 and removed request for a team July 30, 2021 03:37
Jag96
Jag96 approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@Jag96 Jag96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on dev on my emulator 👍

@Jag96 Jag96 merged commit 782ce71 into main Jul 30, 2021
@Jag96 Jag96 deleted the marcaaron-fixFlipperOnAndroid branch July 30, 2021 05:11
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

This was referenced Jul 30, 2021
Closed
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.81-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2021

🚀 Deployed to production in version: 1.0.82-7🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jag96 Jag96 Jag96 approved these changes

Assignees

@marcaaron marcaaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcaaron @botify @OSBotify @Jag96