Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

select default/local currency #4691

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

aman-atg
Copy link
Contributor

@aman-atg aman-atg commented Aug 17, 2021

Details

#4497 (comment)

Fixed Issues

$ #4497

Tests || QA Steps

  1. Login to newDot
  2. Go to any chat
  3. Request Money and choose your currency
  4. Your local currency will be already selected

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

Mobile Web

pr

Desktop

iOS

Android

pr2

@aman-atg aman-atg marked this pull request as ready for review August 17, 2021 15:30
@aman-atg aman-atg requested a review from a team as a code owner August 17, 2021 15:30
@MelvinBot MelvinBot requested review from Beamanator and removed request for a team August 17, 2021 15:30
@Beamanator
Copy link
Contributor

Just to clarify @aman-atg are you unable to test iOS & desktop?

@aman-atg
Copy link
Contributor Author

Yup Sorry for that. Will be getting a macbook in 2-3 days to avoid this.

@Beamanator Beamanator merged commit 083405a into Expensify:main Aug 19, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@aman-atg aman-atg deleted the fix-iouCurrencySelection branch August 30, 2021 14:02
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@botify
Copy link

botify commented Sep 1, 2021

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-08. 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants