Fix: different behavior when using app and device back button in selection mode #46937

nkdengineer · 2024-08-07T03:21:09Z

Details

Fixed Issues

$ #45896
PROPOSAL: #45896 (comment)

Tests

Submit an expense to any user
Go to Search
Long press on the expense
Tap Select
Tap Back button on the top left
Note that only the selection mode is dismissed and app remains on the same page
Tap Select
Go back using device navigation
Verify that: App will dimiss the selection mode and remains on the same page

Verify that no errors appear in the JS console

Offline tests

QA Steps

Submit an expense to any user
Go to Search
Long press on the expense
Tap Select
Tap Back button on the top left
Note that only the selection mode is dismissed and app remains on the same page
Tap Select
Go back using device navigation
Verify that: App will dimiss the selection mode and remains on the same page

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-08-07.at.22.51.29.mov

Android: mWeb Chrome

Screen.Recording.2024-08-15.at.22.19.45.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-mweb.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2024-08-07T08:47:14Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

eVoloshchak · 2024-08-14T13:53:31Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-02-04.at.09.25.41.mov

Android: mWeb Chrome

Screen.Recording.2025-02-04.at.09.27.21.mov

iOS: Native

Screen.Recording.2025-02-04.at.09.34.01.mov

iOS: mWeb Safari

Screen.Recording.2025-02-04.at.09.35.51.mov

MacOS: Chrome / Safari

Screen.Recording.2025-02-04.at.09.37.18.mov

MacOS: Desktop

Screen.Recording.2025-02-04.at.09.36.42.mov

eVoloshchak

@nkdengineer, looking good on native platforms, however, there's still a behavior mismatch on web/mWeb

If you press hardware back button (or back button in browser), the selection isn't dismissed, you're just navigated back
beforeRemove should be of help here
Android: mWeb Chrome screen recording is missing

nkdengineer · 2024-08-19T08:21:58Z

I'll update soon

nkdengineer · 2024-08-21T03:15:26Z

@eVoloshchak I tried with beforeRemove but this event doesn't trigger any time we click on the back button of the browser. Ref here. I also tried with beforeunload but this didn't work.

nkdengineer · 2024-08-26T04:26:24Z

@eVoloshchak What do you think about my comment above?

eVoloshchak · 2024-08-27T13:20:44Z

I tried with beforeRemove but this event doesn't trigger any time we click on the back button of the browser

@nkdengineer, it does according to my testing, but it isn't called when shouldUseNarrowLayout=true (which poses a problem on web and mWeb)

Screen.Recording.2024-08-27.at.15.18.01.mov

nkdengineer · 2024-08-28T05:18:29Z

@nkdengineer, it does according to my testing, but it isn't called when shouldUseNarrowLayout=true (which poses a problem on web and mWeb)

@eVoloshchak Yes this is the problem.

eVoloshchak · 2024-09-02T15:12:39Z

@nkdengineer, that means that, at the very least, we're able to make this work on desktop web (since there beforeRemove works as expected)
But ideally, we need to get to the bottom of "why does it not fire correctly if shouldUseNarrowLayout is true)

nkdengineer · 2024-09-09T02:58:26Z

Still investigating.

nkdengineer · 2024-09-16T09:16:01Z

Still find the RCA of the bug above.

nkdengineer · 2024-09-23T07:12:35Z

Same as above.

nkdengineer · 2024-09-25T09:13:46Z

@eVoloshchak I checked again and beforeRemove also doesn't trigger when we open the search page from the chat on large screen. It's only triggered when we refresh the search page.

Screen.Recording.2024-09-25.at.16.11.06.mp4

nkdengineer · 2024-10-02T07:47:24Z

@eVoloshchak I tried with the listener on Search page and it's the same behavior with you. I am investigating the RCA again.

eVoloshchak · 2024-12-17T12:42:20Z

I think the best way is do nothing in web/mweb

I agree with this
Ultimately, this isn't perfect, as we still end up with a different behavior on native and mWeb. However, I've researched and tested a few methods to 'disable' the browser back button and none of them work reliably and all of them are more of workarounds than supported behavior

nkdengineer · 2024-12-19T08:38:41Z

@eVoloshchak But at the first time we do that, the URL is changed to the previous page but the screen is still the search page, it is also a bug. I think the best way is do nothing in web/mweb.

@Julesssss Currently web/mweb cannot prevent the default behavior when clicking on the back button browser. Do you agree that we can only fix this bug on Native?

Julesssss · 2024-12-20T11:52:20Z

@Julesssss Currently web/mweb cannot prevent the default behavior when clicking on the back button browser. Do you agree that we can only fix this bug on Native?

Yeah I agree with native only. No need to worry about web matching our desired mobile behaviour here.

nkdengineer · 2024-12-23T04:52:31Z

@eVoloshchak We're good to process now.

src/pages/Search/useHandleBackButton/index.android.ts

src/components/Search/SearchContext.tsx

nkdengineer · 2025-01-03T04:19:44Z

Can we instead extend the logic in src/libs/Navigation/setupCustomAndroidBackHandler?

@eVoloshchak I think we can not because we need the onyx data to detect whether we're in the selection mode or not.

nkdengineer · 2025-01-22T09:22:53Z

@eVoloshchak Friendly bump.

src/libs/PolicyUtils.ts

eVoloshchak

LGTM!

Julesssss

Working as expected 👍

OSBotify · 2025-02-04T17:16:03Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-02-06T22:00:28Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.0.95-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-02-11T02:11:47Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.95-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

nkdengineer added 3 commits August 1, 2024 12:57

fix back button in the selection mode

c1afaca

Merge branch 'main' into fix/45896

f617f88

remove useless code

53ea108

nkdengineer marked this pull request as ready for review August 7, 2024 08:47

nkdengineer requested a review from a team as a code owner August 7, 2024 08:47

melvin-bot bot requested review from eVoloshchak and removed request for a team August 7, 2024 08:47

eVoloshchak reviewed Aug 14, 2024

View reviewed changes

nkdengineer added 3 commits August 15, 2024 22:00

Merge branch 'main' into fix/45896

4555031

Merge branch 'main' into fix/45896

cb4ccdb

Merge branch 'main' into fix/45896

097112c

merge main

76efce7

eVoloshchak mentioned this pull request Sep 2, 2024

[Due for payment 2025-02-18] [$250] Search - Different behavior when using app and device back button in selection mode #45896

Closed

6 tasks

resolve conflict

0a69dd9

merge main

4a6cac6

merge main

e7bc518

implement for mWeb

3b91615

merge main

952539c

Merge branch 'main' into fix/45896

9d63337

Merge branch 'main' into fix/45896

3e2e006

fix lint

76c3a61

eVoloshchak suggested changes Dec 29, 2024

View reviewed changes

src/pages/Search/useHandleBackButton/index.android.ts Show resolved Hide resolved

src/components/Search/SearchContext.tsx Outdated Show resolved Hide resolved

Merge branch 'main' into fix/45896

7e11167

Merge branch 'main' into fix/45896

0793384

nkdengineer added 4 commits January 24, 2025 11:13

Merge branch 'main' into fix/45896

ecdc785

fix lint

18cbbe9

update type

3dfac09

fix typecheck

9135bd0

eVoloshchak reviewed Jan 28, 2025

View reviewed changes

src/libs/PolicyUtils.ts Show resolved Hide resolved

Merge branch 'main' into fix/45896

a6d2a1a

eVoloshchak approved these changes Feb 4, 2025

View reviewed changes

melvin-bot bot requested a review from Julesssss February 4, 2025 08:39

Merge branch 'main' into fix/45896

4a708bf

Julesssss approved these changes Feb 4, 2025

View reviewed changes

Julesssss merged commit cd03f19 into Expensify:main Feb 4, 2025
16 checks passed

github-actions bot mentioned this pull request Feb 6, 2025

Deploy Checklist: New Expensify 2025-02-06 #56482

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: different behavior when using app and device back button in selection mode #46937

Fix: different behavior when using app and device back button in selection mode #46937

nkdengineer commented Aug 7, 2024 •

edited

Loading

melvin-bot bot commented Aug 7, 2024

eVoloshchak commented Aug 14, 2024 •

edited

Loading

eVoloshchak left a comment

nkdengineer commented Aug 19, 2024

nkdengineer commented Aug 21, 2024

nkdengineer commented Aug 26, 2024

eVoloshchak commented Aug 27, 2024

nkdengineer commented Aug 28, 2024

eVoloshchak commented Sep 2, 2024

nkdengineer commented Sep 9, 2024

nkdengineer commented Sep 16, 2024

nkdengineer commented Sep 23, 2024

nkdengineer commented Sep 25, 2024

nkdengineer commented Oct 2, 2024

eVoloshchak commented Dec 17, 2024

nkdengineer commented Dec 19, 2024

Julesssss commented Dec 20, 2024

nkdengineer commented Dec 23, 2024

nkdengineer commented Jan 3, 2025

nkdengineer commented Jan 22, 2025

eVoloshchak left a comment

Julesssss left a comment

OSBotify commented Feb 4, 2025

github-actions bot commented Feb 6, 2025

github-actions bot commented Feb 11, 2025

Fix: different behavior when using app and device back button in selection mode #46937

Fix: different behavior when using app and device back button in selection mode #46937

Conversation

nkdengineer commented Aug 7, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 7, 2024

eVoloshchak commented Aug 14, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

eVoloshchak left a comment

Choose a reason for hiding this comment

nkdengineer commented Aug 19, 2024

nkdengineer commented Aug 21, 2024

nkdengineer commented Aug 26, 2024

eVoloshchak commented Aug 27, 2024

nkdengineer commented Aug 28, 2024

eVoloshchak commented Sep 2, 2024

nkdengineer commented Sep 9, 2024

nkdengineer commented Sep 16, 2024

nkdengineer commented Sep 23, 2024

nkdengineer commented Sep 25, 2024

nkdengineer commented Oct 2, 2024

eVoloshchak commented Dec 17, 2024

nkdengineer commented Dec 19, 2024

Julesssss commented Dec 20, 2024

nkdengineer commented Dec 23, 2024

nkdengineer commented Jan 3, 2025

nkdengineer commented Jan 22, 2025

eVoloshchak left a comment

Choose a reason for hiding this comment

Julesssss left a comment

Choose a reason for hiding this comment

OSBotify commented Feb 4, 2025

github-actions bot commented Feb 6, 2025

github-actions bot commented Feb 11, 2025

nkdengineer commented Aug 7, 2024 •

edited

Loading

eVoloshchak commented Aug 14, 2024 •

edited

Loading