Use currentBalance instead of availableBalance

[madmax330]

Details

We're showing the wrong balance to the user. The currentBalance is the one we want the user to see. availableBalance is used on the backend to decide wether or not to authorize transactions.

cc @parasharrajat

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/173152
$ https://github.com/Expensify/Expensify/issues/173151

Tests

• Log into an account with a wallet
• Insert a queued reimbursement with the creditBankAccountID the wallet of the account you are logged in with
• Make sure that you see the balance updated.
• Check that available balance is 0 by running this snippet:

API.get({returnValueList: 'userWallet'}).done(({userWallet}) => {
            console.log(userWallet);
        }).fail((e) => {
            console.log(e);
        });

QA Steps

• Request money from someone
• Have them pay the IOU via bank account, not debit card
• Make sure you see your balance change right after they paid the IOU

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[madmax330]

I have read the CLA Document and I hereby sign the CLA

[parasharrajat]

Ok. Thanks for making a clear distinction. I am working on one of the PR's which deal with this so I will update that.

[Dal-Papa]

Code LGTM

[madmax330]

Updated, only tested on web since there's not actually a UI change.

[stitesExpensify]

You stole my PR! lol jk. Updated your description to include that other issue and merged 👍

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @stitesExpensify in version: 1.0.94-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[isagoico]

@madmax330 Hello! is this testable by us? we tried by adding a fully verified account but the payment option doesn't appear.

[madmax330]

No I put the internalQA label, but apparently it doesn't work the same here as it does for the web app. Sorry, we'll test this internally.

[roryabraham]

Hey y'all, any update on the internal QA here? This is the last item on the checklist blocking a prod deploy.

[yuwenmemon]

Looks like @Jag96 and @kevinksullivan are doing the internal QA for this. What's the latest fellas?

[madmax330]

No it's @joekaufmanexpensify and Kevin. Should be good to check off her soon

[yuwenmemon]

🤦‍♂️ lol Sorry!

[madmax330]

Hence the importance of the Ionatan rule 😆

[kevinksullivan]

QA successful on staging - balance changed after paying an IOU.

[OSBotify]

🚀 Deployed to production by @yuwenmemon in version: 1.0.95-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅