Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integrationtestingcreds to list of Expensify emails #5025

Merged
merged 2 commits into from
Sep 7, 2021
Merged

Add integrationtestingcreds to list of Expensify emails #5025

merged 2 commits into from
Sep 7, 2021

Conversation

deetergp
Copy link
Contributor

@deetergp deetergp commented Sep 2, 2021 •
edited
Loading

Details

Add [email protected] to the list of Expensify emails.

cc @coleaeason

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/173672

Tests

No

QA Steps

No

@deetergp deetergp requested a review from a team as a code owner September 2, 2021 19:14
@deetergp deetergp self-assigned this Sep 2, 2021
@MelvinBot MelvinBot requested review from thienlnam and removed request for a team September 2, 2021 19:15
coleaeason
coleaeason previously approved these changes Sep 2, 2021
View reviewed changes
thienlnam
thienlnam previously approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@thienlnam thienlnam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like now we just need to add it to expensify-common as well

@deetergp deetergp mentioned this pull request Sep 2, 2021
Merged
@deetergp deetergp dismissed stale reviews from thienlnam and coleaeason via b55addc September 2, 2021 21:11
@deetergp
Copy link
Contributor Author

deetergp commented Sep 2, 2021

Sorry to update after getting two approvals, but the word cloud nature of that email list was more than I could bear. Put each entry on its own line for readability's sake.

@deetergp
Copy link
Contributor Author

deetergp commented Sep 7, 2021

Self merging since I've got one full approval from @thienlnam and the only change since @coleaeason's last approval was formatting.

@deetergp deetergp merged commit e746b09 into main Sep 7, 2021
@deetergp deetergp deleted the scott-addIntegrationTestingCreds branch September 7, 2021 16:53
@OSBotify
Copy link
Contributor

OSBotify commented Sep 7, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Sep 8, 2021
Closed
18 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Sep 8, 2021

🚀 Deployed to staging by @deetergp in version: 1.0.94-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Sep 9, 2021

🚀 Deployed to production by @yuwenmemon in version: 1.0.95-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thienlnam thienlnam thienlnam approved these changes

@coleaeason coleaeason coleaeason left review comments

Assignees

@deetergp deetergp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deetergp @OSBotify @coleaeason @thienlnam