Move ExistingOwners view into new component. Reuse confirm modal.

[marcaaron]

cc @aldo-expensify @jasperhuangg

Details

Just moving some things around so that our error handling is easier to follow.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/176349

Tests

1. Follow steps here to get the modal to appear https://stackoverflow.com/c/expensify/questions/10740/10741
2. Verified this modal appears
   
3. Pressed "Got it" and verified it went away
4. Make it appear again
5. Press the link and verify the modal closes and we navigate to the "Company Information" step.

QA Steps

1. Create a policy and add User A and User B
2. Create bank account in open state with User A (via OldDot or via the /bank-account flow in NewDot)
3. Attempt to create bank account as User B in NewDot via the /bank-account flow
4. Verified this modal appears
5. Press "Got it" and verify it goes away
6. Make it appear again (add the same account)
7. Press the hyperlink and verify the modal closes and we navigate to the "Company Information" step.

Note: This cannot be QA'd on native platforms yet as the Plaid staging credentials do not work in NewDot yet.

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

[marcaaron]

@joelbettner do you happen to know much about what an "existing copy" is or when we'd show this?
I couldn't figure out how to surface this error organically.

[aldo-expensify]

Looks good.

Found a problem, see comment below.

Double checking something...

[aldo-expensify]

If you click the blue link in the modal, it takes you to the Company step, but the modal stays there and the error changes to the generic error -> the modal should hide. If you try this in the main branch, it takes you to the Company step, but the modal leaves.

Screen.Recording.2021-09-03.at.4.54.52.PM.mov

On a side note and out of the scope of this PR: the blue link is taking the user to the company step, is this correct?

[marcaaron]

On a side note and out of the scope of this PR: the blue link is taking the user to the company step, is this correct?

I'll look into this today thanks!

[marcaaron]

the blue link is taking the user to the company step, is this correct

AFAIK this is correct. We handle the link the same way in OldDot.

[marcaaron]

OK, fixed the issue with the modal not closing. Still unsure exactly how to trigger the existing copies warning in staging.

[marcaaron]

Ok figured this out and added a SO post here

[aldo-expensify]

Looks good. Tested in Android and web.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @aldo-expensify in version: 1.0.94-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[isagoico]

@marcaaron Hello! This PR was a pass in web. We were unable to verify this on Android because of this issue #5075. Are we good to check it off?

[marcaaron]

I think that's fine I left a "note" in the description about this.

[OSBotify]

🚀 Deployed to production by @yuwenmemon in version: 1.0.95-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅