Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check isOnfidoSetupComplete in the requestor step to prevent showing it again #5330

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

ctkochan22
Copy link
Contributor

@ctkochan22 ctkochan22 commented Sep 17, 2021

@marcaaron
cc @nkuoch @Jag96

Details

Even though onfido completes are we are waiting on Onfido's webhook response as to the verification of the onfido data, we shouldn't let the user loop back.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/177843

Tests / QA Steps

We need to check on all platforms. You can follow both flows num. 1 and num 2. The key is to make sure you go through the onfido flow on all platforms.

  1. Get to requestorstep or "Personal Information"
  2. Continue and you should go through onfido
  3. Upon uploading the video (the last onfido step), you should continue to Beneficial owners step.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@ctkochan22 ctkochan22 requested a review from a team as a code owner September 17, 2021 21:02
@ctkochan22 ctkochan22 self-assigned this Sep 17, 2021
@MelvinBot MelvinBot requested review from madmax330 and removed request for a team September 17, 2021 21:02
Copy link
Contributor

@marcaaron marcaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

Copy link
Contributor

@Jag96 Jag96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests pass

@marcaaron marcaaron merged commit 267f640 into main Sep 17, 2021
@marcaaron marcaaron deleted the ckt_freeplan_checkOnfidoState branch September 17, 2021 21:50
github-actions bot pushed a commit that referenced this pull request Sep 17, 2021
Check isOnfidoSetupComplete in the requestor step to prevent showing it again

(cherry picked from commit 267f640)
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @marcaaron in version: 1.0.99-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Jag96 in version: 1.0.99-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @marcaaron in version: 1.0.99-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Jag96 in version: 1.1.0-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants