-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check isOnfidoSetupComplete in the requestor step to prevent showing it again #5330
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tests pass
Check isOnfidoSetupComplete in the requestor step to prevent showing it again (cherry picked from commit 267f640)
🚀 Cherry-picked to staging by @marcaaron in version: 1.0.99-3 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to staging by @marcaaron in version: 1.0.99-5 🚀
|
@marcaaron
cc @nkuoch @Jag96
Details
Even though onfido completes are we are waiting on Onfido's webhook response as to the verification of the onfido data, we shouldn't let the user loop back.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/177843
Tests / QA Steps
We need to check on all platforms. You can follow both flows num. 1 and num 2. The key is to make sure you go through the onfido flow on all platforms.
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android