Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Skip showing create for new users if user already has a workspace" #5360

Merged

Conversation

bondydaa
Copy link
Contributor

Reverts #5244 so we can unblock the new dot deploy and get the latest code out for testing and such

cc @Beamanator

@bondydaa bondydaa self-assigned this Sep 20, 2021
@bondydaa bondydaa requested a review from a team as a code owner September 20, 2021 19:03
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@MelvinBot MelvinBot requested review from jasperhuangg and removed request for a team September 20, 2021 19:04
@Jag96
Copy link
Contributor

Jag96 commented Sep 20, 2021

Clean revert, no need to wait for e2e tests. Merging.

@Jag96 Jag96 merged commit 499c65a into main Sep 20, 2021
@Jag96 Jag96 deleted the revert-5244-beaman-skipShowingCreateForNewUsersIfHasWorkspace branch September 20, 2021 19:08
github-actions bot pushed a commit that referenced this pull request Sep 20, 2021
…gCreateForNewUsersIfHasWorkspace

Revert "Skip showing create for new users if user already has a workspace"

(cherry picked from commit 499c65a)
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @Jag96 in version: 1.0.99-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Jag96 in version: 1.0.99-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Jag96 in version: 1.0.99-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Jag96 in version: 1.1.0-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants