Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase global create modal delay to 1500ms #5369

Merged
merged 4 commits into from
Sep 20, 2021
Merged

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham commented Sep 20, 2021

Details

Hopefully temporary workaround until #5296 is resolved.

Fixed Issues

$ #5303

Tests / QA Steps

  1. Log in with a user that's never signed into New Expensify before.
    • Dev-only tip: Emulate this by setting the following NVP:

      UPDATE nameValuePairs SET value = 'true' WHERE name = 'isFirstTimeNewExpensifyUser' AND accountID = INSERT_ACCOUNT_ID_HERE;
  2. Ensure that the global create popover menu is correctly displayed.
  3. Log back out and sign in with the same user.
  4. The global create popover menu should not automatically open.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen.Recording.2021-09-20.at.2.38.45.PM.mov

Mobile Web

Screen.Recording.2021-09-20.at.2.43.13.PM.mov

Desktop

Screen.Recording.2021-09-20.at.2.46.20.PM.mov

iOS

Screen.Recording.2021-09-20.at.2.15.37.PM.mov

Android

@roryabraham roryabraham requested a review from a team as a code owner September 20, 2021 21:22
@roryabraham roryabraham self-assigned this Sep 20, 2021
@MelvinBot MelvinBot requested review from deetergp and removed request for a team September 20, 2021 21:23
# Conflicts:
#	src/pages/home/sidebar/SidebarScreen.js
@roryabraham roryabraham requested a review from Jag96 September 20, 2021 21:45
Copy link
Contributor

@luacmartins luacmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tests well.

@Jag96 Jag96 merged commit 112bad2 into main Sep 20, 2021
@Jag96 Jag96 deleted the Rory-IncreaseModalTimeout branch September 20, 2021 22:49
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@roryabraham
Copy link
Contributor Author

Should we CP this? When I created this the checklist was still unlocked.

@Jag96
Copy link
Contributor

Jag96 commented Sep 20, 2021

Ah good point, yeah I can CP manually

github-actions bot pushed a commit that referenced this pull request Sep 20, 2021
Increase global create modal delay to 1500ms

(cherry picked from commit 112bad2)
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @Jag96 in version: 1.1.0-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Jag96 in version: 1.1.0-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Jag96 in version: 1.1.0-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Jag96 in version: 1.1.1-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants