fix: add missing violation data #54603

daledah · 2024-12-27T09:21:28Z

Explanation of Change

Fixed Issues

$ #54510
PROPOSAL: #54510 (comment)

Tests

Precondition: Control workspace

Steps:

Go Offline
Create an expense with big amount and set to a future date
Go to WS chat
Verify that: RBR is shown
Open expense report
Verify that: RBR and error text is displayed in receipt, amount and date field.

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Precondition: Control workspace

Steps:

Go Offline
Create an expense with big amount and set to a future date
Go to WS chat
Verify that: RBR is shown
Open expense report
Verify that: RBR and error text is displayed in receipt, amount and date field.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-12-27.at.12.37.14.mov

Android: mWeb Chrome

Screen.Recording.2024-12-27.at.12.38.46.mov

iOS: Native

Screen.Recording.2024-12-27.at.12.40.46.mov

iOS: mWeb Safari

Screen.Recording.2024-12-27.at.12.41.54.mov

MacOS: Chrome / Safari

Screen.Recording.2024-12-27.at.12.15.54.mov

MacOS: Desktop

Screen.Recording.2024-12-27.at.12.42.34.mov

melvin-bot · 2024-12-30T09:09:36Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/Violations/ViolationsUtils.ts

tests/unit/ViolationUtilsTest.ts

…code

src/libs/Violations/ViolationsUtils.ts

s77rt · 2025-01-06T17:44:25Z

src/libs/DateUtils.ts

+/**
+ * Checks if the input time is after the reference date
+ * param {Date} inputDate - The date to validate.
+ * returns {boolean} - Returns true if the input date is after the reference date, otherwise false.
+ */
+const isFutureDate = (inputDate: Date): boolean => {
+    return isAfter(startOfDay(inputDate), startOfDay(new Date()));
+};
+


Can we remove startOfDay?

In getDayValidationErrorKey we use startOfDay so I think it would be more accurate and consistent to use it here as well

Let's not use isFutureDate then because this would give incorrect results if you pass current date + few hours, it will be false.

@s77rt In my opinion:

Currently, we don't have logics to select expense hour/minutes, only select date. We can consider this as time is not taken into account when checking for violations.

The violation is ""Future date not allowed"", so it's best to compare dates only.
That's why I think comparing hours here is out of scope and should be addressed in another issue if we want to change current behavior.
What do you think?

Let's not keep the function named isFutureDate because its implementation is misleading. Let's do the following:

Rename isFutureDate to isFutureDay

Use that function in getDayValidationErrorKey

Logics in getDayValidationErrorKey and isFutureDay returns false for today and opposite value for other days, so using isFutureDay inside getDayValidationErrorKey will cause regressions on status clear after page:

In logics, we expect:

getDayValidationErrorKey to return empty (false) on future and today, error (true) on past

isFutureDay to return true on future, false on today and past

tests/unit/ViolationUtilsTest.ts

src/pages/iou/request/step/IOURequestStepAmount.tsx

src/libs/Violations/ViolationsUtils.ts

src/libs/actions/IOU.ts

s77rt · 2025-01-14T15:57:12Z

@daledah Please prioritize this and let me know when it's ready for review

daledah · 2025-01-15T10:30:36Z

@s77rt I updated.

Also, regarding #54603 (comment), tracking expenses (which uses Personal workspace), future date violation is not applied, so I think it's only applied for control WS.

Screen.Recording.2025-01-15.at.14.15.02.mov

src/libs/Violations/ViolationsUtils.ts

src/libs/actions/IOU.ts

s77rt · 2025-01-15T19:21:35Z

The amount comparison is not taking currency into account.

Screen.Recording.2025-01-15.at.7.25.44.PM.mov

s77rt · 2025-01-15T19:23:13Z

Can you also check #54603 (comment) it seems to be unresolved yet

daledah · 2025-01-16T16:26:42Z

Regarding #54603 (comment), because we don't have any logics to compare amounts with different currencies, I think it's out of scope and we should address it in another issue.

s77rt · 2025-01-17T14:29:16Z

Can you please resolve the conflicts

src/libs/actions/IOU.ts

s77rt · 2025-01-20T10:17:14Z

This is still unresolved https://github.com/Expensify/App/pull/54603/files#r1920274495

s77rt · 2025-01-20T10:35:33Z

In the test steps, specify that the workspace should be on Control plan.

s77rt · 2025-01-20T10:42:09Z

The receipt and amount errors are missing for a workspace that has currecny different than USD

Screen.Recording.2025-01-20.at.11.39.38.AM.mov

s77rt · 2025-01-20T10:52:40Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mweb-chrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

mweb-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

s77rt · 2025-01-28T09:58:29Z

@daledah Can you please prioritize this?

daledah · 2025-01-29T12:22:51Z

@s77rt Sorry for the delay, I'll update soon.

daledah · 2025-02-06T03:45:11Z

@s77rt I updated.
Also, removing startOfDay creates a bug that violation shows even if the day selected is today, so I kept it.
Other change is that overLimit and receiptRequired are shown in control WS without any other conditions, so I updated that too.

s77rt · 2025-02-06T12:49:38Z

@daledah We can keep the use of startOfDay but let's not use isFutureDate because this function would be misleading as explained in the case highlighted here https://github.com/Expensify/App/pull/54603/files#r1920274495

Also this comment is still not addressed #54603 (comment)

OSBotify · 2025-02-08T17:48:05Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-02-11T02:38:05Z

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.0.96-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-02-12T01:43:36Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.96-1 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

daledah added 4 commits December 27, 2024 16:19

fix: add missing violation data

87a8010

fix: lint

8e3ecda

fix: violation test

5b40b67

fix: add new tests for violation utils

b81691d

daledah marked this pull request as ready for review December 30, 2024 09:09

daledah requested a review from a team as a code owner December 30, 2024 09:09

melvin-bot bot requested review from s77rt and removed request for a team December 30, 2024 09:09

s77rt suggested changes Dec 30, 2024

View reviewed changes

src/libs/Violations/ViolationsUtils.ts Outdated Show resolved Hide resolved

src/libs/Violations/ViolationsUtils.ts Outdated Show resolved Hide resolved

src/libs/Violations/ViolationsUtils.ts Outdated Show resolved Hide resolved

tests/unit/ViolationUtilsTest.ts Outdated Show resolved Hide resolved

fix: change future date violation logics and tests, remove redundant …

5a9b1a0

…code

s77rt suggested changes Jan 6, 2025

View reviewed changes

daledah added 2 commits January 13, 2025 14:00

Merge branch 'main' into fix/54510

227f2de

fix: change future date condition, update amount logic

e127c19

s77rt suggested changes Jan 14, 2025

View reviewed changes

src/pages/iou/request/step/IOURequestStepAmount.tsx Outdated Show resolved Hide resolved

src/libs/Violations/ViolationsUtils.ts Outdated Show resolved Hide resolved

src/libs/actions/IOU.ts Outdated Show resolved Hide resolved

daledah added 5 commits January 15, 2025 14:23

fix: add invoice condition

8e28783

Merge branch 'main' into fix/54510

23063e7

Merge branch 'main' into fix/54510

c52fbd4

fix: lint

6c253ae

fix: lint

3fcc56b

s77rt reviewed Jan 15, 2025

View reviewed changes

src/libs/Violations/ViolationsUtils.ts Outdated Show resolved Hide resolved

src/libs/actions/IOU.ts Outdated Show resolved Hide resolved

fix: remove redundant variables

0f45efa

Merge branch 'main' into fix/54510

c925f8c

s77rt suggested changes Jan 20, 2025

View reviewed changes

src/libs/actions/IOU.ts Outdated Show resolved Hide resolved

daledah added 3 commits February 5, 2025 21:14

Merge branch 'main' into fix/54510

36218d8

fix: update logics for violation

d7da91b

test: fix test cases for ViolationUtils

6efb40b

Merge branch 'main' into fix/54510

9859441

daledah added 3 commits February 8, 2025 19:08

Merge branch 'main' into fix/54510

932e540

refactor: change functions names

03bb392

fix: Lint

23e7448

s77rt approved these changes Feb 8, 2025

View reviewed changes

melvin-bot bot requested a review from carlosmiceli February 8, 2025 17:32

carlosmiceli approved these changes Feb 8, 2025

View reviewed changes

carlosmiceli merged commit 631006e into Expensify:main Feb 8, 2025
17 checks passed

github-actions bot mentioned this pull request Feb 11, 2025

Deploy Checklist: New Expensify 2025-02-11 #56625

Closed

69 tasks

melvin-bot bot mentioned this pull request Feb 12, 2025

[Due for payment 2025-02-19] [$250] Expense - In offline, expense created with violation red dot not shown in preview #54510

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: add missing violation data #54603

fix: add missing violation data #54603

daledah commented Dec 27, 2024 •

edited

Loading

melvin-bot bot commented Dec 30, 2024

s77rt Jan 6, 2025

daledah Jan 16, 2025

s77rt Jan 17, 2025

daledah Feb 7, 2025 •

edited

Loading

s77rt Feb 7, 2025

daledah Feb 8, 2025 •

edited

Loading

s77rt commented Jan 14, 2025

daledah commented Jan 15, 2025

s77rt commented Jan 15, 2025

s77rt commented Jan 15, 2025

daledah commented Jan 16, 2025

s77rt commented Jan 17, 2025

s77rt commented Jan 20, 2025

s77rt commented Jan 20, 2025

s77rt commented Jan 20, 2025

s77rt commented Jan 20, 2025 •

edited

Loading

s77rt commented Jan 28, 2025

daledah commented Jan 29, 2025

daledah commented Feb 6, 2025

s77rt commented Feb 6, 2025

OSBotify commented Feb 8, 2025

github-actions bot commented Feb 11, 2025

github-actions bot commented Feb 12, 2025

fix: add missing violation data #54603

fix: add missing violation data #54603

Conversation

daledah commented Dec 27, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 30, 2024

s77rt Jan 6, 2025

Choose a reason for hiding this comment

daledah Jan 16, 2025

Choose a reason for hiding this comment

s77rt Jan 17, 2025

Choose a reason for hiding this comment

daledah Feb 7, 2025 • edited Loading

Choose a reason for hiding this comment

s77rt Feb 7, 2025

Choose a reason for hiding this comment

daledah Feb 8, 2025 • edited Loading

Choose a reason for hiding this comment

s77rt commented Jan 14, 2025

daledah commented Jan 15, 2025

s77rt commented Jan 15, 2025

s77rt commented Jan 15, 2025

daledah commented Jan 16, 2025

s77rt commented Jan 17, 2025

s77rt commented Jan 20, 2025

s77rt commented Jan 20, 2025

s77rt commented Jan 20, 2025

s77rt commented Jan 20, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

s77rt commented Jan 28, 2025

daledah commented Jan 29, 2025

daledah commented Feb 6, 2025

s77rt commented Feb 6, 2025

OSBotify commented Feb 8, 2025

github-actions bot commented Feb 11, 2025

github-actions bot commented Feb 12, 2025

daledah commented Dec 27, 2024 •

edited

Loading

daledah Feb 7, 2025 •

edited

Loading

daledah Feb 8, 2025 •

edited

Loading

s77rt commented Jan 20, 2025 •

edited

Loading