[CP Stg] Add Venmo only if sending money #5661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
thienlnam
approved these changes
Oct 5, 2021
13 tasks
Jag96
approved these changes
Oct 5, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Oct 5, 2021
(cherry picked from commit e99bd02)
|
🚀 Cherry-picked to staging by @thienlnam in version: 1.1.5-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
Retest was a pass 🎉 Checking it off the list |
13 tasks
|
🚀 Deployed to production by @chiragsalian in version: 1.1.5-1 🚀
|
|
🚀 Deployed to staging by @thienlnam in version: 1.1.5-2 🚀
|
|
🚀 Deployed to production by @chiragsalian in version: 1.1.6-0 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR needs to be tested on a staging environment since simulators cannot download Venmo locally from the App Store.
Fixed Issues
$ #5655
Tests / QA Steps
Precondition: installed the Venmo app and log in with it.
2. Log in with phone account number, e.g. (+14016597742)
3. Click on user with phone number e.g. (used +15082211196) and click
Request Money4. Put amount and Continue
5. Verify only one green button appears with
Request $XTested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android