Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Route to the main workspace screen now that it is in rightpane #5747

Merged
merged 1 commit into from
Oct 11, 2021
Merged

Route to the main workspace screen now that it is in rightpane #5747

merged 1 commit into from
Oct 11, 2021

Conversation

Gonals
Copy link
Contributor

@Gonals Gonals commented Oct 11, 2021 •
edited
Loading

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/180748

Tests/ QA Steps

  1. Log into oldDot
  2. Go to Settings->Policies->New Policy and Select Free
  3. You should be redirected to NewDot. Make sure the main workspace screen opens in rightpane (not the card one):

Screen Shot 2021-10-11 at 12 08 57 PM

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

@Gonals Gonals self-assigned this Oct 11, 2021
@Gonals Gonals requested a review from a team as a code owner October 11, 2021 10:09
@MelvinBot MelvinBot requested review from nkuoch and removed request for a team October 11, 2021 10:09
@Gonals Gonals changed the title [WIP] Route to the main workspace screen now that it is in rightpane Route to the main workspace screen now that it is in rightpane Oct 11, 2021
@Gonals
Copy link
Contributor Author

Gonals commented Oct 11, 2021

Off WIP!

@Gonals Gonals added the n6-hold label Oct 11, 2021
@nkuoch nkuoch merged commit 00d3ea4 into main Oct 11, 2021
@nkuoch nkuoch deleted the alberto-routeCard branch October 11, 2021 11:58
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions bot pushed a commit that referenced this pull request Oct 14, 2021
@nkuoch
Merge pull request #5747 from Expensify/alberto-routeCard
35c0dea 
Route to the main workspace screen now that it is in rightpane

(cherry picked from commit 00d3ea4)
@OSBotify OSBotify mentioned this pull request Oct 14, 2021
Closed
github-actions bot pushed a commit that referenced this pull request Oct 14, 2021
@nkuoch
Merge pull request #5747 from Expensify/alberto-routeCard
5fa22a9 
Route to the main workspace screen now that it is in rightpane

(cherry picked from commit 00d3ea4)
@OSBotify OSBotify mentioned this pull request Oct 14, 2021
Merged
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @AndrewGable in version: 1.1.7-20 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

This was referenced Oct 14, 2021
Closed
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.7-24 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @nkuoch in version: 1.1.7-25 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkuoch nkuoch nkuoch approved these changes

Assignees

@Gonals Gonals

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gonals @OSBotify @nkuoch