-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close sidebar when going to concierge chat #5779
Conversation
|
Updated |
@parasharrajat I like that you're refactoring this behavior out into a CustomAction. Considering that this is a time-sensitive fix, could we merge this PR and then have you pull master on yours? That way we can have this quick fix done, and then give you the credit for abstracting this into more reusable behavior. Thoughts @tgolen? |
I have done all changes and someone just needs to review that and I will follow along till merge and finish all changes asap. But it's fine if you want to proceed that way. I will mark this change and remove it on my PR. |
Ok cool! I'll merge this one, and then add myself on as a reviewer for your PR. That way Tim will get credit for the quick work he's done here, and then Marc and I can review your PR without the time crunch. It seems pretty close to completion but I never underestimate Marc's ability to find things to change. |
Tested well 👍 |
Close sidebar when going to concierge chat (cherry picked from commit 1dae7dc)
🚀 Cherry-picked to staging by @Luke9389 in version: 1.1.7-6 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by @AndrewGable in version: 1.1.7-24 🚀
|
🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀
|
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/180850
Tests / QA Steps
Tested On
Screenshots
n/a
Web
n/a
Mobile Web
n/a
Desktop
n/a
iOS
n/a
Android
n/a