Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close sidebar when going to concierge chat #5779

Merged
merged 2 commits into from
Oct 12, 2021
Merged

Conversation

tgolen
Copy link
Contributor

@tgolen tgolen commented Oct 12, 2021

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/180850

Tests / QA Steps

  1. Have a bank account added to your account and a workspace created
  2. Go to Settings > Workspace > Book travel
  3. Click on the link to book travel with Concierge
  4. Verify that you are taken to the concierge chat and the sidebar closes

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

n/a

Web

n/a

Mobile Web

n/a

Desktop

n/a

iOS

n/a

Android

n/a

@tgolen tgolen requested a review from a team October 12, 2021 17:50
@tgolen tgolen self-assigned this Oct 12, 2021
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@MelvinBot MelvinBot requested review from MariaHCD and removed request for a team October 12, 2021 17:51
@tgolen tgolen requested review from Luke9389 and removed request for MariaHCD October 12, 2021 17:52
@parasharrajat
Copy link
Member

parasharrajat commented Oct 12, 2021

@tgolen I am fixing it in a good way here. #5131. Please take a look if you got time. Thanks.

@tgolen tgolen requested a review from a team as a code owner October 12, 2021 18:20
@tgolen
Copy link
Contributor Author

tgolen commented Oct 12, 2021

Updated

@MelvinBot MelvinBot requested review from marcochavezf and removed request for a team October 12, 2021 18:21
@Luke9389
Copy link
Contributor

@parasharrajat I like that you're refactoring this behavior out into a CustomAction. Considering that this is a time-sensitive fix, could we merge this PR and then have you pull master on yours? That way we can have this quick fix done, and then give you the credit for abstracting this into more reusable behavior. Thoughts @tgolen?

@parasharrajat
Copy link
Member

parasharrajat commented Oct 12, 2021

I have done all changes and someone just needs to review that and I will follow along till merge and finish all changes asap.

But it's fine if you want to proceed that way. I will mark this change and remove it on my PR.

@Luke9389
Copy link
Contributor

Ok cool! I'll merge this one, and then add myself on as a reviewer for your PR. That way Tim will get credit for the quick work he's done here, and then Marc and I can review your PR without the time crunch. It seems pretty close to completion but I never underestimate Marc's ability to find things to change.

@Luke9389
Copy link
Contributor

Tested well 👍

@Luke9389 Luke9389 merged commit 1dae7dc into main Oct 12, 2021
@Luke9389 Luke9389 deleted the tgolen-travel-link branch October 12, 2021 19:27
github-actions bot pushed a commit that referenced this pull request Oct 12, 2021
Close sidebar when going to concierge chat

(cherry picked from commit 1dae7dc)
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @Luke9389 in version: 1.1.7-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.7-24 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Luke9389 in version: 1.1.7-25 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants