Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🍒 Cherry pick PR #5776 to staging 🍒 #5785

Merged
merged 3 commits into from
Oct 12, 2021
Merged

🍒 Cherry pick PR #5776 to staging 🍒 #5785

merged 3 commits into from
Oct 12, 2021

Conversation

OSBotify
Copy link
Contributor

🍒 Cherry pick #5776 to staging 🍒

OSBotify and others added 2 commits October 12, 2021 19:01
@OSBotify
Merge pull request #5784 from Expensify/version-BUILD-d66c278fa543f90…
05aacc2 
…723949e5180c9b565cee140c1

(cherry picked from commit dd22d0e)
@aldo-expensify
Merge pull request #5776 from Expensify/tgolen-offline-links
ffa6541 
Show growl when clicking on links in offline mode

(cherry picked from commit d66c278)
@OSBotify OSBotify requested a review from a team as a code owner October 12, 2021 19:01
@MelvinBot MelvinBot removed the request for review from a team October 12, 2021 19:01
@OSBotify
Copy link
Contributor Author

This pull request has merge conflicts and can not be automatically merged. 😞
Please manually resolve the conflicts, push your changes, and then request another reviewer to review and merge.
Important: There may be conflicts that GitHub is not able to detect, so please carefully review this pull request before approving.

@aldo-expensify aldo-expensify requested a review from tgolen October 12, 2021 19:21
@tgolen tgolen merged commit 297c07d into staging Oct 12, 2021
@tgolen tgolen deleted the OSBotify-cherry-pick-staging-5776 branch October 12, 2021 19:23
@OSBotify
Copy link
Contributor Author

🚀 Cherry-picked to staging by @tgolen in version: 1.1.7-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor Author

🚀 Deployed to production by @AndrewGable in version: 1.1.7-24 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgolen tgolen tgolen approved these changes

Assignees

@aldo-expensify aldo-expensify

Labels
automerge Engineering Hourly KSv2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OSBotify @tgolen @aldo-expensify