Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tooltip for workspace name #5812

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Added tooltip for workspace name #5812

merged 1 commit into from
Oct 13, 2021

Conversation

akshayasalvi
Copy link
Contributor

Details

  • Added tooltip to the workspace name

Fixed Issues

$ #5772

Tests

  1. Tested the Workspace name tooltip on all platforms
  2. Ensured that nothing breaks in mobile platforms

QA Steps

  1. Go to the sidebar
  2. Click on any workspacename
  3. Hover over the workspace name, it should show the Tooltip

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web-tooltip-workspace-name

Mobile Web

NA

Desktop

desktop-tooltip-workspace-name

iOS

NA

Android

NA

@akshayasalvi akshayasalvi requested a review from a team as a code owner October 13, 2021 18:06
@MelvinBot MelvinBot requested review from Beamanator and removed request for a team October 13, 2021 18:06
parasharrajat
parasharrajat approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@parasharrajat parasharrajat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tests well on all platforms. Ready for merge @Beamanator

Beamanator
Beamanator approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@Beamanator Beamanator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

@Beamanator Beamanator merged commit a77d468 into Expensify:main Oct 13, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Oct 15, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Beamanator in version: 1.1.7-25 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@isagoico isagoico mentioned this pull request Oct 16, 2021
Closed
@isagoico
Copy link

This issue is failing this PR #5907

@akshayasalvi
Copy link
Contributor Author

akshayasalvi commented Oct 16, 2021 •
edited
Loading

@Beamanator @parasharrajat Can you help with the staging branch name? I checked in the main branch it is working fine. Possible that it wasn't deployed or got removed in some merge conflict?

I can find the Tooltip import but not the Tooltip usage part in the deployed tag 1.1.7-25

Screenshots here
#5907 (comment)

@Beamanator
Copy link
Contributor

Investigating in related Issue #5907 🙃

@roryabraham
Copy link
Contributor

Discussed in #5907, but this PR was partially overwritten on staging by a bad merge commit. So I'm going to manually CP this to staging.

github-actions bot pushed a commit that referenced this pull request Oct 18, 2021
@Beamanator
Merge pull request #5812 from akshayasalvi/tooltip-workspace-name
42b5016 
Added tooltip for workspace name

(cherry picked from commit a77d468)
@OSBotify OSBotify mentioned this pull request Oct 18, 2021
Merged
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @roryabraham in version: 1.1.8-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@ogumen
Copy link

ogumen commented Oct 22, 2021

The tooltip cannot be hovered over using mouse pointer, and cannot be dismissed using keyboard without moving mouse pointer. When user tries to hover over the tooltip with the mouse pointer, it disappears. When pressing Esc key to dismiss the tooltip popup, the entire workspace overlay gets dismissed. It is a failure of WCAG SC 1.4.13
Expensify_Workspace overlay_Tooltip popup is not hoverable with mouse pointer or dismissable using keyboard

@botify botify mentioned this pull request Oct 23, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

1 similar comment
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@mountiny mountiny mentioned this pull request Nov 1, 2021
Closed
@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Beamanator Beamanator Beamanator approved these changes

@parasharrajat parasharrajat parasharrajat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@akshayasalvi @OSBotify @isagoico @Beamanator @roryabraham @ogumen @parasharrajat