Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link to OldDot's reports page #5813

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Fix link to OldDot's reports page #5813

merged 1 commit into from
Oct 13, 2021

Conversation

francoisl
Copy link
Contributor

@francoisl francoisl commented Oct 13, 2021 •
edited
Loading

Details

Fix a link to OldDot's reports page

Fixed Issues

$ #5799

Tests / QA Steps

  1. Using an account that has a VBA, click on your avatar
  2. Click on a workspace
  3. Click on Reimburse Receipts, then Reimburse Receipts
  4. Make sure a new tab opens to the reports page on OldDot, and that the page loads as expected

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Screen.Recording.2021-10-13.at.11.10.24.AM.mov

@francoisl francoisl requested a review from a team as a code owner October 13, 2021 18:14
@francoisl francoisl self-assigned this Oct 13, 2021
@francoisl
Copy link
Contributor Author

Applying the CPStaging label since it resolves a deploy blocker.

@MelvinBot MelvinBot removed the request for review from a team October 13, 2021 18:15
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

timszot
timszot approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@timszot timszot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM feel free to merge once travis is happy.

@francoisl francoisl merged commit dd80fc9 into main Oct 13, 2021
@francoisl francoisl deleted the francois-fixReimburseReceiptsOldDotLink branch October 13, 2021 19:18
github-actions bot pushed a commit that referenced this pull request Oct 13, 2021
@francoisl
Merge pull request #5813 from Expensify/francois-fixReimburseReceipts…
9558678 
…OldDotLink

Fix link to OldDot's reports page

(cherry picked from commit dd80fc9)
This was referenced Oct 13, 2021
Merged
Closed
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @francoisl in version: 1.1.7-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify OSBotify mentioned this pull request Oct 15, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.7-24 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @francoisl in version: 1.1.7-25 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timszot timszot timszot approved these changes

@thienlnam thienlnam thienlnam approved these changes

@jasperhuangg jasperhuangg Awaiting requested review from jasperhuangg

Assignees

@francoisl francoisl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@francoisl @OSBotify @timszot @thienlnam