Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Fix api usage inside AddEncryptedAuthToken migration #6915

Merged

Conversation

kidroca
Copy link
Contributor

@kidroca kidroca commented Dec 28, 2021

@marcaaron

Details

Fixes a problem related to migrating usages to import *
Looks like it was only applied partially here

Fixed Issues

$ N/A

Tests

QA Steps

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

image

@kidroca kidroca requested a review from a team as a code owner December 28, 2021 21:18
@MelvinBot MelvinBot requested review from ctkochan22 and removed request for a team December 28, 2021 21:19
ctkochan22
ctkochan22 previously approved these changes Dec 28, 2021
Copy link
Contributor

@ctkochan22 ctkochan22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple change. @marcaaron let you merge

Copy link
Contributor

@marcaaron marcaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This was on my list of things to fix, but never found the time to do it. Guessing not many were affected, but it was a careless mistake.

@marcaaron marcaaron merged commit 74738c3 into Expensify:main Dec 30, 2021
@marcaaron
Copy link
Contributor

Looks great, thanks again!

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Jan 4, 2022

🚀 Deployed to staging by @marcaaron in version: 1.1.24-19 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 failure ❌

@OSBotify
Copy link
Contributor

OSBotify commented Jan 4, 2022

🚀 Deployed to production by @francoisl in version: 1.1.24-19 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants