Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-native-bootsplash to 3.2.7 #6950

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Update react-native-bootsplash to 3.2.7 #6950

merged 1 commit into from
Jan 3, 2022

Conversation

zoontek
Copy link
Contributor

@zoontek zoontek commented Dec 30, 2021

Following #5620

Details

Update react-native-bootsplash module to 3.2.7 in order to apply these changes: #5620 (comment)
This update doesn't affect Android (no changes).

Fixed Issues

#5620 (maybe? reproduction steps are not known)

Tests

QA Steps

  • Starts the app on iOS, check if the splash screen is visible then disappear
  • Retry by starting the app using a push notification
  • Retry by putting the app on background before the app init, then put the app on foreground again

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

iOS

Copy link
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay @zoontek - was out of office for the end of year holidays. This looks good 👍

@NikkiWines NikkiWines merged commit eceb132 into Expensify:main Jan 3, 2022
@OSBotify
Copy link
Contributor

OSBotify commented Jan 4, 2022

🚀 Deployed to staging by @NikkiWines in version: 1.1.24-19 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 failure ❌

@OSBotify
Copy link
Contributor

OSBotify commented Jan 4, 2022

🚀 Deployed to production by @francoisl in version: 1.1.24-19 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 failure ❌

@zoontek zoontek deleted the update-react-native-bootsplash branch February 16, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants