Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🍒 Cherry pick PR #6951 to staging 🍒 #6964

Merged
merged 3 commits into from
Dec 30, 2021
Merged

🍒 Cherry pick PR #6951 to staging 🍒 #6964

merged 3 commits into from
Dec 30, 2021

Conversation

OSBotify
Copy link
Contributor

🍒 Cherry pick #6951 to staging 🍒

OSBotify and others added 2 commits December 30, 2021 21:22
@OSBotify
Merge pull request #6963 from Expensify/version-BUILD-9c8af65fd4cee6a…
d757a18 
…25d9e7f33c51ba90fd59f37b0

(cherry picked from commit 7fcb02c)
@aldo-expensify @OSBotify
Merge pull request #6951 from parasharrajat/room-page
dd6232e 
fix: room page layout
(cherry picked from commit e787423)
@OSBotify OSBotify requested a review from a team as a code owner December 30, 2021 21:22
@MelvinBot MelvinBot removed the request for review from a team December 30, 2021 21:22
@OSBotify
Copy link
Contributor Author

This pull request has merge conflicts and can not be automatically merged. 😞
Please manually resolve the conflicts, push your changes, and then request another reviewer to review and merge.
Important: There may be conflicts that GitHub is not able to detect, so please carefully review this pull request before approving.

@AndrewGable AndrewGable self-requested a review December 30, 2021 21:37
@aldo-expensify
Copy link
Contributor

woo was looking for a reviewer, thanks!

@AndrewGable AndrewGable merged commit 8db8dae into staging Dec 30, 2021
@AndrewGable AndrewGable deleted the AndrewGable-cherry-pick-staging-6951 branch December 30, 2021 21:38
@OSBotify
Copy link
Contributor Author

🚀 Cherry-picked to staging by @AndrewGable in version: 1.1.24-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor Author

OSBotify commented Jan 4, 2022

🚀 Deployed to production by @francoisl in version: 1.1.24-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewGable AndrewGable AndrewGable approved these changes

Assignees

@AndrewGable AndrewGable

@aldo-expensify aldo-expensify

Labels
automerge Engineering Hourly KSv2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OSBotify @aldo-expensify @AndrewGable