Fix maxLength data type #7086
Merged
Fix maxLength data type #7086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MelvinBot
requested review from
tylerkaraszewski
and removed request for
a team
|
Woo, good catch! I didn't imagine that change could create a cast issue in RN. Thanks for addressing that Carlos! (I owe you 2 tacos hehe) |
marcochavezf
approved these changes
Jan 7, 2022
|
Self-merging with approval! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
24 tasks
|
🚀 Deployed to staging by @luacmartins in version: 1.1.26-2 🚀
|
|
🚀 Deployed to staging by @luacmartins in version: 1.1.27-0 🚀
|
|
🚀 Deployed to production by @roryabraham in version: 1.1.27-1 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Introduced here #6845 cc @marcochavezf
Fixes data type for maxLength prop.
Fixed Issues
$ #7085
Tests
Settings > Payments > Add payment method > Debit cardQA Steps
Steps above.
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android
android-2.mov