Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only passing sections that contain data #7285

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Conversation

chiragsalian
Copy link
Contributor

@chiragsalian chiragsalian commented Jan 17, 2022

Details

Seems like there is some funkiness with the Sections component that i don't completely get. If we pass sections with empty data it sorta screws up the view when we enter a custom email or phone when the component never had non-empty values before. Removing the empty data values seems to have resolved the issue.

Fixed Issues

$ #7032
$ #6945

Tests / QA

  1. Create a new account.
  2. Create a workspace, then click on profile -> the workspace -> Manage members -> invite -> Type a random valid email.
  3. Confirm it shows up below the input as a clickable option.
    image
  4. Close this sidebar. Then click on the green plus icon on the bottom and select request money. Enter an amount and then a valid email.
  5. Confirm the email shows up below the input as a clickable option.
    image
  6. Also on mobile i tested logging into an exiting account and going to request money/ manage members and confirming the existing list of recent and contacts scroll just fine. i.e., confirmed this issue didn't occur again.

QA Steps

  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@chiragsalian chiragsalian self-assigned this Jan 17, 2022
@chiragsalian chiragsalian marked this pull request as ready for review January 17, 2022 20:41
@chiragsalian chiragsalian requested a review from a team as a code owner January 17, 2022 20:41
@MelvinBot MelvinBot requested review from neil-marcellini and removed request for a team January 17, 2022 20:42
Copy link
Contributor

@neil-marcellini neil-marcellini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests work and it looks like the issues have been fixed.

@neil-marcellini neil-marcellini merged commit cd8130f into main Jan 18, 2022
@neil-marcellini neil-marcellini deleted the chirag-option-fix branch January 18, 2022 18:13
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @neil-marcellini in version: 1.1.30-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @chiragsalian in version: 1.1.31-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants