[NO QA]Run tests and lint on merge into main #7632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mountiny
previously approved these changes
Feb 8, 2022
roryabraham
requested changes
Feb 9, 2022
There was a problem hiding this comment.
Is your intention to prevent preDeploy from triggering a staging deploy if tests fail? If so, I think you need to make other jobs, particularly version, dependent upon the results of the confirmPassingBuilds job using the needs keyword and the job-level if clause for the version job.
|
Got it - I thought that we could just rely on that one job failing to fail the workflow, but I will make that explicit change 👍 |
|
Ok so I think the latest changes will do what we want? Basically if lint or tests do not pass, don't continue the deploy workflow? |
roryabraham
approved these changes
Feb 10, 2022
85 tasks
|
🚀 Deployed to staging by @roryabraham in version: 1.1.39-0 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Runs both the lint and test workflows when we merge code into
main, which will hopefully prevent us from trying to deploy unlinted code that will cause the builds to fail.Fixed Issues
$ #7026
Tests
QA Steps
N/A
Tested On
N/A