Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove notification Subheader #7692

Merged
merged 2 commits into from
Feb 11, 2022

Conversation

mateusbra
Copy link
Contributor

@mateusbra mateusbra commented Feb 10, 2022

Details

Remove notification Subheader

Fixed Issues

$ #7670

Tests | QA Steps

  1. Click "+"
  2. Click "New room"
  3. Add any room name, choose any workspace, choose any visibility setting - Click "Create room"
  4. Click the room header in the main chat pane to be taken to the room "Setting" pane
  5. Verify notification Subheader was removed.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

Mobile Web

image

Desktop

Captura de Tela 2022-02-10 às 21 33 57

iOS

Captura de Tela 2022-02-10 às 14 14 40

Android

image

@mateusbra mateusbra requested a review from a team as a code owner February 10, 2022 23:04
@Julesssss Julesssss requested review from roryabraham and removed request for a team February 11, 2022 10:35
@Julesssss Julesssss requested review from a team and removed request for roryabraham February 11, 2022 10:36
@MelvinBot MelvinBot requested review from Julesssss and parasharrajat and removed request for a team February 11, 2022 10:36
@Julesssss
Copy link
Contributor

Ignore that @roryabraham, I missclicked.

@Julesssss
Copy link
Contributor

Actually, I'm holding my review for now, as I'm unable to open the settings menu. I tried updating all repos with no luck 😕

Screenshot 2022-02-11 at 11 57 27

Copy link
Member

@parasharrajat parasharrajat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

cc: @Julesssss.

🎀 👀 🎀 C+ reviewed

@mateusbra
Copy link
Contributor Author

@Julesssss I had this issue a few times on IOS. I tryed to reload the app and it worked for me.

@Julesssss Julesssss merged commit 1e70a89 into Expensify:main Feb 11, 2022
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@Julesssss
Copy link
Contributor

God knows what the issue was, but I was finally able to verify!

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Julesssss in version: 1.1.39-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @timszot in version: 1.1.39-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants