P2P KYC - Handle Idology questions and errors #7813

nkuoch · 2022-02-18T10:01:06Z

Details

HOLD on Add RadioButton components #8009
Add more address fields
Show Idology Questions when needed
Handle Idology errors and copies

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/193505
$ https://github.com/Expensify/Expensify/issues/193504

Tests

See comments below

QA Steps

None, under beta and will be tested as a whole once everything is done

Tested On

nkuoch · 2022-02-20T13:27:47Z

Tested the Idology Questions flow.

You need to have your IP whitelisted by Idology.

In src/setup/index.js, hardcode window.Onyx = Onyx; so you can later access it from your console.

Access http://localhost:8080/settings/payments/enable-payments

Run in the console: Onyx.merge('userWallet', {currentStep: 'AdditionalDetailsStep'});

Enter the info as in the screenshot (double check the address as the google autocomplete tends to mess it up) then Save & Continue

After 5 questions badly answered, you're redirected to the KYC failed page:

botify · 2022-02-22T16:34:53Z

Hey, I noticed you changed some webpack configuration files. This can break production builds. Did you remember to run a production build locally to verify they still work?

nkuoch · 2022-03-02T14:40:48Z

Tested birthDate error:

Tested address error:

Tested ssn error:

Tested lastName error:

Tested combining 2 errors:

Tested combining 3 errors:

And in spanish:

ctkochan22 · 2022-03-07T07:07:38Z

Looks good. Going to test first thing tomorrow

nkuoch · 2022-03-08T19:59:02Z

Ok, I rebased main, squashed all my commits together so it's cleaner, forced push, and now that it's not holding on anything anymore, it's ready to be reviewed, tested and merged!

marcaaron

Really great stuff, thanks for the changes. Just spotted a few minor things after doing a full review. Will give it a test first thing tomorrow.

marcaaron · 2022-03-10T07:01:52Z

src/libs/actions/Wallet.js

-                        CONST.WALLET.ERROR.UNEXPECTED,
-                        CONST.WALLET.ERROR.UNABLE_TO_VERIFY,
-                    ];
+                    let qualifiers = _.get(response, ['data', 'requestorIdentityID', 'apiResult', 'qualifiers', 'qualifier'], []);


Oh yeah small thing but we have standardized on using lodashGet(). A get() was added to underscore in a recent version, but doesn't have the path based syntax like (lodashGet(response, 'data. requestorIdentityID.apiResult.etc')) so we avoid using it to keep things consistent.

marcaaron · 2022-03-10T07:08:35Z

src/libs/actions/Wallet.js

+                        }
+                    }
+
+                    if (_.get(response, ['data', 'requestorIdentityID', 'apiResult', 'results', 'key']) === 'result.no.match'


lodashGet()

marcaaron · 2022-03-10T07:13:44Z

src/pages/EnablePayments/IdologyQuestions.js

+    render() {
+        const questionIndex = this.state.questionNumber;
+        const question = this.props.questions[questionIndex] || {};
+        const possibleAnwers = _.filter(_.map(question.answer, (answer) => {


Suggested change

const possibleAnwers = _.filter(_.map(question.answer, (answer) => {

const possibleAnswers = _.filter(_.map(question.answer, (answer) => {

nkuoch · 2022-03-10T14:45:25Z

Updated

…ilsDraft

marcaaron

Looks great thanks!

OSBotify · 2022-03-14T21:09:48Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-03-15T21:36:30Z

🚀 Deployed to staging by @marcaaron in version: 1.1.43-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2022-03-17T17:56:27Z

🚀 Deployed to production by @roryabraham in version: 1.1.43-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

nkuoch self-assigned this Feb 18, 2022

nkuoch force-pushed the nat-p2pkycquestions branch 3 times, most recently from 4aba17e to 3cc5916 Compare February 20, 2022 13:20

nkuoch force-pushed the nat-p2pkycquestions branch 3 times, most recently from bfa36b6 to c6adaa3 Compare February 22, 2022 12:37

nkuoch force-pushed the nat-p2pkycquestions branch from c6adaa3 to fb8574e Compare February 22, 2022 17:01

nkuoch mentioned this pull request Feb 22, 2022

fix: crash when value is undefined #7782

Merged

7 tasks

nkuoch force-pushed the nat-p2pkycquestions branch 7 times, most recently from 9c18087 to 9cdf993 Compare February 28, 2022 12:40

nkuoch marked this pull request as ready for review February 28, 2022 12:41

nkuoch requested a review from a team as a code owner February 28, 2022 12:41

nkuoch removed the request for review from a team February 28, 2022 12:41

MelvinBot requested a review from PauloGasparSv February 28, 2022 12:41

nkuoch removed the request for review from PauloGasparSv February 28, 2022 12:41

nkuoch force-pushed the nat-p2pkycquestions branch 5 times, most recently from 370137c to f9350d3 Compare March 1, 2022 16:11

nkuoch force-pushed the nat-p2pkycquestions branch from f9350d3 to 1ed21d8 Compare March 2, 2022 14:42

nkuoch changed the title ~~P2P KYC - Handle Idology questions and errors~~ [HOLD] P2P KYC - Handle Idology questions and errors Mar 4, 2022

nkuoch force-pushed the nat-p2pkycquestions branch from 995ec14 to 5457046 Compare March 8, 2022 19:46

nkuoch changed the title ~~[HOLD] P2P KYC - Handle Idology questions and errors~~ P2P KYC - Handle Idology questions and errors Mar 8, 2022

P2P KYC - Handle Idology errors and questions

27b5777

nkuoch force-pushed the nat-p2pkycquestions branch from 5457046 to 27b5777 Compare March 8, 2022 19:50

Expensify deleted a comment from marcaaron Mar 8, 2022

Expensify deleted a comment from shawnborton Mar 8, 2022

ctkochan22 previously approved these changes Mar 10, 2022

View reviewed changes

marcaaron requested changes Mar 10, 2022

View reviewed changes

Use nextStepValues and fix typo

9f74fc2

nkuoch dismissed ctkochan22’s stale review via 9f74fc2 March 10, 2022 09:17

nkuoch added 2 commits March 10, 2022 10:31

Add unit tests for Wallet.buildIdologyError

f1e8581

Merge branch 'main' into nat-p2pkycquestions

c4f2d63

nkuoch force-pushed the nat-p2pkycquestions branch from f38fb95 to 0b9f587 Compare March 14, 2022 13:03

Remove useless state, as we are already updating walletAdditionalDeta…

42459e3

…ilsDraft

nkuoch force-pushed the nat-p2pkycquestions branch from 0b9f587 to 42459e3 Compare March 14, 2022 14:33

ctkochan22 approved these changes Mar 14, 2022

View reviewed changes

marcaaron self-requested a review March 14, 2022 18:57

marcaaron approved these changes Mar 14, 2022

View reviewed changes

marcaaron merged commit c1bb574 into main Mar 14, 2022

marcaaron deleted the nat-p2pkycquestions branch March 14, 2022 21:00

OSBotify mentioned this pull request Mar 15, 2022

Deploy Checklist: New Expensify 2022-03-15 #8170

Closed

52 tasks

roryabraham mentioned this pull request Mar 16, 2022

Android - Connect bank account - App is crashed after selecting Save & Continue button #8177

Closed

SumitDiyora mentioned this pull request Apr 9, 2022

Deploy Checklist: New Expensify 2022-03-10 #8074

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

P2P KYC - Handle Idology questions and errors #7813

P2P KYC - Handle Idology questions and errors #7813

nkuoch commented Feb 18, 2022 •

edited

Loading

nkuoch commented Feb 20, 2022 •

edited

Loading

botify commented Feb 22, 2022

nkuoch commented Mar 2, 2022 •

edited

Loading

ctkochan22 commented Mar 7, 2022

nkuoch commented Mar 8, 2022 •

edited

Loading

marcaaron left a comment

marcaaron Mar 10, 2022

marcaaron Mar 10, 2022

marcaaron Mar 10, 2022

nkuoch commented Mar 10, 2022

marcaaron left a comment

OSBotify commented Mar 14, 2022

OSBotify commented Mar 15, 2022

OSBotify commented Mar 17, 2022

	const possibleAnwers = _.filter(_.map(question.answer, (answer) => {
	const possibleAnswers = _.filter(_.map(question.answer, (answer) => {

P2P KYC - Handle Idology questions and errors #7813

P2P KYC - Handle Idology questions and errors #7813

Conversation

nkuoch commented Feb 18, 2022 • edited Loading

Details

Fixed Issues

Tests

QA Steps

Tested On

nkuoch commented Feb 20, 2022 • edited Loading

botify commented Feb 22, 2022

nkuoch commented Mar 2, 2022 • edited Loading

ctkochan22 commented Mar 7, 2022

nkuoch commented Mar 8, 2022 • edited Loading

marcaaron left a comment

Choose a reason for hiding this comment

marcaaron Mar 10, 2022

Choose a reason for hiding this comment

marcaaron Mar 10, 2022

Choose a reason for hiding this comment

marcaaron Mar 10, 2022

Choose a reason for hiding this comment

nkuoch commented Mar 10, 2022

marcaaron left a comment

Choose a reason for hiding this comment

OSBotify commented Mar 14, 2022

OSBotify commented Mar 15, 2022

OSBotify commented Mar 17, 2022

nkuoch commented Feb 18, 2022 •

edited

Loading

nkuoch commented Feb 20, 2022 •

edited

Loading

nkuoch commented Mar 2, 2022 •

edited

Loading

nkuoch commented Mar 8, 2022 •

edited

Loading