Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix date picker label #8041

Merged
merged 1 commit into from
Mar 8, 2022
Merged

fix date picker label #8041

merged 1 commit into from
Mar 8, 2022

Conversation

thesahindia
Copy link
Member

@thesahindia thesahindia commented Mar 8, 2022 •
edited by luacmartins
Loading

Details

Fixed Issues

Fixed overlapping datePicker label

$ #7963

Tests

  1. Go to settings
  2. Open any workspace
  3. Go to connect bank account
  4. Go to connect manually
  5. Go to 2nd step (Company Information)
  6. Decrease the screen size
  7. Reload the page
  8. Verify incorporation date label doesn't overlap with the value
  • Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

  • I verified the PR has a small number of commits behind main
  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I clearly indicated the environment tests should be run in (Staging vs Production)
  • I wrote testing steps that cover success & fail scenarios (if applicable)
  • I included screenshots or videos for tests on all platforms
  • I ran the tests & veryfy they passed on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • I verified there are no console errors related to changes in this PR
  • I followed proper code patterns (see Reviewing the code)
    • I added comments when the code was not self explanatory
    • I put all copy / text shown in the product in all src/languages/* files (if applicable)
    • I followed proper naming convention for platform-specific files (if applicable)
    • I followed style guidelines (in Styling.md) for all style edits I made
    • I followed the JSDocs style guidelines (in STYLE.md)
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I corroborated the UI performance was not affected (the performance is the same than main branch)
  • If I created a new component I verified that a similar component doesn't exist in the codebase

PR Reviewer Checklist

  • I verified the PR has a small number of commits behind main
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the testing environment is mentioned in the test steps
  • I verified testing steps cover success & fail scenarios (if applicable)
  • I checked that screenshots or videos are included for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • I verified there are no console errors related to changes in this PR
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified comments were added when the code was not self explanatory
    • I verified any copy / text shown in the product was added in all src/languages/* files (if applicable)
    • I verified proper naming convention for platform-specific files was followed (if applicable)
    • I verified style guidelines were followed
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components are not impacted by changes in this PR (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified the UI performance was not affected (the performance is the same than main branch)
  • If a new component is created I verified that a similar component doesn't exist in the codebase

QA Steps

  1. Go to settings
  2. Open any workspace
  3. Go to connect bank account
  4. Go to connect manually
  5. Go to 2nd step (Company Information)
  6. Decrease the screen size
  7. Reload the page
  8. Verify incorporation date label doesn't overlap with the value
  • Verify that no errors appear in the JS console

Screenshots

Web

Screen.Recording.2022-03-08.at.10.04.47.PM.mov

Mobile Web

Screenshot 2022-03-08 at 10 06 03 PM

Desktop

Screenshot 2022-03-08 at 9 47 04 PM

iOS

Screenshot 2022-03-08 at 9 48 04 PM

Android

Screenshot 2022-03-08 at 9 57 28 PM

@thesahindia thesahindia requested a review from a team as a code owner March 8, 2022 17:15
@MelvinBot MelvinBot requested review from luacmartins and Santhosh-Sellavel and removed request for a team March 8, 2022 17:15
luacmartins
luacmartins approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@luacmartins luacmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested well! Thanks @thesahindia!

@Santhosh-Sellavel
Copy link
Collaborator

Santhosh-Sellavel commented Mar 8, 2022 •
edited
Loading

PR Reviewer Checklist

  • I verified the PR has a small number of commits behind main
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the testing environment is mentioned in the test steps
  • I verified testing steps cover success & fail scenarios (if applicable)
  • I checked that screenshots or videos are included for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • I verified there are no console errors related to changes in this PR
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified comments were added when the code was not self explanatory
    • I verified any copy / text shown in the product was added in all src/languages/* files (if applicable)
    • I verified proper naming convention for platform-specific files was followed (if applicable)
    • I verified style guidelines were followed
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components are not impacted by changes in this PR (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified the UI performance was not affected (the performance is the same than main branch)
  • If a new component is created I verified that a similar component doesn't exist in the codebase

@Santhosh-Sellavel
Copy link
Collaborator

@thesahindia Could you please add a video for iOS & mWeb & android

Santhosh-Sellavel
Santhosh-Sellavel approved these changes Mar 8, 2022
View reviewed changes
Copy link
Collaborator

@Santhosh-Sellavel Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested works well, LGTM!

@luacmartins luacmartins merged commit 9c534aa into Expensify:main Mar 8, 2022
@OSBotify
Copy link
Contributor

OSBotify commented Mar 8, 2022

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Mar 10, 2022
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @luacmartins in version: 1.1.42-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@kavimuru kavimuru mentioned this pull request Mar 11, 2022
Closed
@botify botify mentioned this pull request Mar 15, 2022
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @chiragsalian in version: 1.1.42-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

This was referenced Apr 9, 2022
Closed
Closed
Closed
@SumitDiyora SumitDiyora mentioned this pull request Apr 20, 2022
Closed
22 tasks
@rushatgabhane
Copy link
Member

rushatgabhane commented Nov 8, 2022 •
edited
Loading

dropping a note that this caused a regression - #11973

cause: On android, Firefox always shows mm / dd / yyyy

@rushatgabhane rushatgabhane mentioned this pull request Nov 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luacmartins luacmartins luacmartins approved these changes

@Santhosh-Sellavel Santhosh-Sellavel Santhosh-Sellavel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thesahindia @Santhosh-Sellavel @OSBotify @rushatgabhane @luacmartins